qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Li Qiang <liq3ea@163.com>
To: armbru@redhat.com
Cc: qemu-devel@nongnu.org, Li Qiang <liq3ea@163.com>
Subject: [Qemu-devel] [PATCH] tests: check-qjson: fix a memory leak
Date: Tue,  2 Oct 2018 09:26:52 -0700	[thread overview]
Message-ID: <20181002162652.19377-1-liq3ea@163.com> (raw)

Spotted by ASAN.

=================================================================
==17531==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 1120 byte(s) in 28 object(s) allocated from:
    #0 0x7f9fb85eeb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50)
    #1 0x7f9fb824b8d8 in g_malloc (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x518d8)
    #2 0x5654ae94f073 in qstring_from_str qobject/qstring.c:66
    #3 0x5654ae94ede7 in qstring_new qobject/qstring.c:23
    #4 0x5654ae953b6b in parse_string qobject/json-parser.c:143
    #5 0x5654ae955e3e in parse_literal qobject/json-parser.c:484
    #6 0x5654ae956227 in parse_value qobject/json-parser.c:547
    #7 0x5654ae9565c7 in json_parser_parse qobject/json-parser.c:573
    #8 0x5654ae952d5d in json_message_process_token qobject/json-streamer.c:92
    #9 0x5654ae9608fa in json_lexer_feed_char qobject/json-lexer.c:313
    #10 0x5654ae960ea5 in json_lexer_feed qobject/json-lexer.c:350
    #11 0x5654ae9530de in json_message_parser_feed qobject/json-streamer.c:121
    #12 0x5654ae950b6e in qobject_from_jsonv qobject/qjson.c:69
    #13 0x5654ae950d30 in qobject_from_json qobject/qjson.c:83
    #14 0x5654ae9449af in from_json_str tests/check-qjson.c:30
    #15 0x5654ae946399 in utf8_string tests/check-qjson.c:781
    #16 0x7f9fb826cc39  (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72c39)

Signed-off-by: Li Qiang <liq3ea@163.com>
---
 tests/check-qjson.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index cc13f3d41e..d876a7a96e 100644
--- a/tests/check-qjson.c
+++ b/tests/check-qjson.c
@@ -780,6 +780,7 @@ static void utf8_string(void)
             if (!strstr(json_out, "\\uFFFD")) {
                 str = from_json_str(json_out, j, &error_abort);
                 g_assert_cmpstr(qstring_get_try_str(str), ==, utf8_in);
+                qobject_unref(str);
             }
         }
     }
-- 
2.17.1

             reply	other threads:[~2018-10-02 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 16:26 Li Qiang [this message]
2018-10-02 16:43 ` [Qemu-devel] [PATCH] tests: check-qjson: fix a memory leak Eric Blake
2018-10-02 16:49 ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002162652.19377-1-liq3ea@163.com \
    --to=liq3ea@163.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).