qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	eblake@redhat.com, Kevin Wolf <kwolf@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	vsementsov@virtuozzo.com, Fam Zheng <famz@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps
Date: Tue,  2 Oct 2018 19:02:18 -0400	[thread overview]
Message-ID: <20181002230218.13949-7-jsnow@redhat.com> (raw)
In-Reply-To: <20181002230218.13949-1-jsnow@redhat.com>

Whether it's "locked" or "frozen", it's in use and should
not be allowed for the purposes of this operation.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 nbd/server.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/nbd/server.c b/nbd/server.c
index c3dd402b45..940b7aa0cd 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -2478,8 +2478,8 @@ void nbd_export_bitmap(NBDExport *exp, const char *bitmap,
         return;
     }
 
-    if (bdrv_dirty_bitmap_qmp_locked(bm)) {
-        error_setg(errp, "Bitmap '%s' is locked", bitmap);
+    if (bdrv_dirty_bitmap_user_locked(bm)) {
+        error_setg(errp, "Bitmap '%s' is in use", bitmap);
         return;
     }
 
-- 
2.14.4

  parent reply	other threads:[~2018-10-02 23:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 23:02 [Qemu-devel] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions John Snow
2018-10-02 23:02 ` [Qemu-devel] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked status checker John Snow
2018-10-03 12:19   ` Eric Blake
2018-10-03 12:47   ` Vladimir Sementsov-Ogievskiy
2018-10-03 18:28     ` John Snow
2018-10-03 18:39       ` Eric Blake
2018-10-02 23:02 ` [Qemu-devel] [PATCH v4 2/6] block/dirty-bitmaps: fix merge permissions John Snow
2018-10-03 12:20   ` Eric Blake
2018-10-03 13:01   ` Vladimir Sementsov-Ogievskiy
2018-10-02 23:02 ` [Qemu-devel] [PATCH v4 3/6] block/dirty-bitmaps: allow clear on disabled bitmaps John Snow
2018-10-03 12:21   ` Eric Blake
2018-10-03 13:02   ` Vladimir Sementsov-Ogievskiy
2018-10-02 23:02 ` [Qemu-devel] [PATCH v4 4/6] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps John Snow
2018-10-03 12:23   ` Eric Blake
2018-10-03 13:05   ` Vladimir Sementsov-Ogievskiy
2018-10-02 23:02 ` [Qemu-devel] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps John Snow
2018-10-03 12:28   ` Eric Blake
2018-10-03 13:21     ` Vladimir Sementsov-Ogievskiy
2018-10-03 16:43     ` John Snow
2018-10-03 14:04   ` Vladimir Sementsov-Ogievskiy
2018-10-02 23:02 ` John Snow [this message]
2018-10-03 12:31   ` [Qemu-devel] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps Eric Blake
2018-10-03 14:06   ` Vladimir Sementsov-Ogievskiy
2018-10-02 23:08 ` [Qemu-devel] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions John Snow
2018-10-17 20:29   ` Eric Blake
2018-10-03 20:28 ` John Snow
2018-10-17 18:24 ` Eric Blake
2018-10-17 18:28   ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002230218.13949-7-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).