* [Qemu-devel] [PATCH] gtk: fix uninitialized variable
@ 2018-10-03 12:11 Paolo Bonzini
2018-10-03 13:16 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2018-10-03 12:11 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel
zoom_to_fit is never initialized to false, Coverity complains
(not sure why GCC does not).
Fixes: e8b1386ea1719525a1a92df03377764703fe8c64
Cc: kraxel@redhat.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
ui/gtk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 3ddb5fe162..ec935fff90 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2136,7 +2136,7 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc,
QemuConsole *con, int idx,
GSList *group, GtkWidget *view_menu)
{
- bool zoom_to_fit;
+ bool zoom_to_fit = false;
vc->label = qemu_console_get_label(con);
vc->s = s;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] gtk: fix uninitialized variable
2018-10-03 12:11 [Qemu-devel] [PATCH] gtk: fix uninitialized variable Paolo Bonzini
@ 2018-10-03 13:16 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-03 13:16 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: kraxel
On 03/10/2018 14:11, Paolo Bonzini wrote:
> zoom_to_fit is never initialized to false, Coverity complains
> (not sure why GCC does not).
>
> Fixes: e8b1386ea1719525a1a92df03377764703fe8c64
> Cc: kraxel@redhat.com
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 3ddb5fe162..ec935fff90 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -2136,7 +2136,7 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc,
> QemuConsole *con, int idx,
> GSList *group, GtkWidget *view_menu)
> {
> - bool zoom_to_fit;
> + bool zoom_to_fit = false;
>
> vc->label = qemu_console_get_label(con);
> vc->s = s;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-03 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-03 12:11 [Qemu-devel] [PATCH] gtk: fix uninitialized variable Paolo Bonzini
2018-10-03 13:16 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).