From: Kevin Wolf <kwolf@redhat.com>
To: Anton Nefedov <anton.nefedov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com,
armbru@redhat.com, jsnow@redhat.com, pbonzini@redhat.com,
famz@redhat.com, eblake@redhat.com, den@virtuozzo.com,
berto@igalia.com
Subject: Re: [Qemu-devel] [PATCH v4 7/8] file-posix: account discard operations
Date: Thu, 4 Oct 2018 17:52:00 +0200 [thread overview]
Message-ID: <20181004155200.GJ6009@localhost.localdomain> (raw)
In-Reply-To: <1534844779-118784-8-git-send-email-anton.nefedov@virtuozzo.com>
Am 21.08.2018 um 11:46 hat Anton Nefedov geschrieben:
> This will help to identify how many of the user-issued discard operations
> (accounted on a device level) have actually suceeded down on the host file
> (even though the numbers will not be exactly the same if non-raw format
> driver is used (e.g. qcow2 sending metadata discards)).
>
> Note that these numbers will not include discards triggered by
> write-zeroes + MAY_UNMAP calls.
>
> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Why not implement accounting at the BDS level for all drivers? Then we
can also reuse the existing BlockStats fields instead of duplicating
them into driver-specific new ones.
Kevin
next prev parent reply other threads:[~2018-10-04 15:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 9:46 [Qemu-devel] [PATCH v4 0/8] discard blockstats Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 1/8] qapi: group BlockDeviceStats fields Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 2/8] qapi: add unmap to BlockDeviceStats Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 3/8] ide: account UNMAP (TRIM) operations Anton Nefedov
2018-10-04 15:33 ` Kevin Wolf
2018-10-08 14:38 ` Anton Nefedov
2018-10-08 15:03 ` Kevin Wolf
2018-10-08 15:25 ` Anton Nefedov
2018-10-08 15:46 ` Kevin Wolf
2018-10-08 16:04 ` Anton Nefedov
2018-10-08 16:43 ` Kevin Wolf
2018-10-17 15:32 ` Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 4/8] scsi: store unmap offset and nb_sectors in request struct Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 5/8] scsi: move unmap error checking to the complete callback Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 6/8] scsi: account unmap operations Anton Nefedov
2018-10-04 15:47 ` Kevin Wolf
2018-10-08 14:43 ` Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 7/8] file-posix: account discard operations Anton Nefedov
2018-10-04 15:52 ` Kevin Wolf [this message]
2018-10-08 13:47 ` Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 8/8] qapi: query-blockstat: add driver specific file-posix stats Anton Nefedov
[not found] ` <6d0b2d5b-f0a4-b62c-3dc4-e8d92eeb76b2@virtuozzo.com>
2018-10-04 14:04 ` [Qemu-devel] [PATCH v4 0/8] discard blockstats Anton Nefedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004155200.GJ6009@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=anton.nefedov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).