From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8Mou-00081U-Ez for qemu-devel@nongnu.org; Fri, 05 Oct 2018 05:54:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g8Mot-0000sh-Jn for qemu-devel@nongnu.org; Fri, 05 Oct 2018 05:54:52 -0400 Date: Fri, 5 Oct 2018 11:54:46 +0200 From: Cornelia Huck Message-ID: <20181005115446.339e5759.cohuck@redhat.com> In-Reply-To: <1538732546-2284-1-git-send-email-thuth@redhat.com> References: <1538732546-2284-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Set a category for the generic-loader device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Alistair Francis On Fri, 5 Oct 2018 11:42:26 +0200 Thomas Huth wrote: > Each device that is instantiatable by the users should be marked with > a category. Since the generic-loader does not fit anywhere else, put > it into the MISC category. > > Signed-off-by: Thomas Huth > --- > hw/core/generic-loader.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/core/generic-loader.c b/hw/core/generic-loader.c > index fde32cb..be29ae1 100644 > --- a/hw/core/generic-loader.c > +++ b/hw/core/generic-loader.c > @@ -204,6 +204,7 @@ static void generic_loader_class_init(ObjectClass *klass, void *data) > dc->unrealize = generic_loader_unrealize; > dc->props = generic_loader_props; > dc->desc = "Generic Loader"; > + set_bit(DEVICE_CATEGORY_MISC, dc->categories); > } > > static TypeInfo generic_loader_info = { Reviewed-by: Cornelia Huck