qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL v2 11/12] hostmem: add some properties description
Date: Fri,  5 Oct 2018 16:29:09 +0400	[thread overview]
Message-ID: <20181005122910.11745-12-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20181005122910.11745-1-marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
 backends/hostmem-memfd.c |  9 +++++++++
 backends/hostmem.c       | 14 ++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c
index 3800bd07b6..b6836b28e5 100644
--- a/backends/hostmem-memfd.c
+++ b/backends/hostmem-memfd.c
@@ -145,16 +145,25 @@ memfd_backend_class_init(ObjectClass *oc, void *data)
                                        memfd_backend_get_hugetlb,
                                        memfd_backend_set_hugetlb,
                                        &error_abort);
+        object_class_property_set_description(oc, "hugetlb",
+                                              "Use huge pages",
+                                              &error_abort);
         object_class_property_add(oc, "hugetlbsize", "int",
                                   memfd_backend_get_hugetlbsize,
                                   memfd_backend_set_hugetlbsize,
                                   NULL, NULL, &error_abort);
+        object_class_property_set_description(oc, "hugetlbsize",
+                                              "Huge pages size (ex: 2M, 1G)",
+                                              &error_abort);
     }
     if (qemu_memfd_check(MFD_ALLOW_SEALING)) {
         object_class_property_add_bool(oc, "seal",
                                        memfd_backend_get_seal,
                                        memfd_backend_set_seal,
                                        &error_abort);
+        object_class_property_set_description(oc, "seal",
+                                              "Seal growing & shrinking",
+                                              &error_abort);
     }
 }
 
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 4908946cd3..1a89342039 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -397,27 +397,41 @@ host_memory_backend_class_init(ObjectClass *oc, void *data)
     object_class_property_add_bool(oc, "merge",
         host_memory_backend_get_merge,
         host_memory_backend_set_merge, &error_abort);
+    object_class_property_set_description(oc, "merge",
+        "Mark memory as mergeable", &error_abort);
     object_class_property_add_bool(oc, "dump",
         host_memory_backend_get_dump,
         host_memory_backend_set_dump, &error_abort);
+    object_class_property_set_description(oc, "dump",
+        "Set to 'off' to exclude from core dump", &error_abort);
     object_class_property_add_bool(oc, "prealloc",
         host_memory_backend_get_prealloc,
         host_memory_backend_set_prealloc, &error_abort);
+    object_class_property_set_description(oc, "prealloc",
+        "Preallocate memory", &error_abort);
     object_class_property_add(oc, "size", "int",
         host_memory_backend_get_size,
         host_memory_backend_set_size,
         NULL, NULL, &error_abort);
+    object_class_property_set_description(oc, "size",
+        "Size of the memory region (ex: 500M)", &error_abort);
     object_class_property_add(oc, "host-nodes", "int",
         host_memory_backend_get_host_nodes,
         host_memory_backend_set_host_nodes,
         NULL, NULL, &error_abort);
+    object_class_property_set_description(oc, "host-nodes",
+        "Binds memory to the list of NUMA host nodes", &error_abort);
     object_class_property_add_enum(oc, "policy", "HostMemPolicy",
         &HostMemPolicy_lookup,
         host_memory_backend_get_policy,
         host_memory_backend_set_policy, &error_abort);
+    object_class_property_set_description(oc, "policy",
+        "Set the NUMA policy", &error_abort);
     object_class_property_add_bool(oc, "share",
         host_memory_backend_get_share, host_memory_backend_set_share,
         &error_abort);
+    object_class_property_set_description(oc, "share",
+        "Mark the memory as private to QEMU or shared", &error_abort);
 }
 
 static const TypeInfo host_memory_backend_info = {
-- 
2.19.0.271.gfe8321ec05

  parent reply	other threads:[~2018-10-05 12:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 12:28 [Qemu-devel] [PULL v2 00/12] Option patches Marc-André Lureau
2018-10-05 12:28 ` [Qemu-devel] [PULL v2 01/12] qdev-monitor: print help to stdout Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 02/12] cutils: add qemu_pstrcmp0() Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 03/12] qemu-option: add help fallback to print the list of options Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 04/12] qemu-option: improve qemu_opts_print_help() output Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 05/12] qom/object: fix iterating properties over a class Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 06/12] qom/object: register 'type' property as class property Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 07/12] tests/qom-proplist: check duplicate "bv" property registration failed Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 08/12] tests/qom-proplist: check properties are not listed multiple times Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 09/12] tests/qom-proplist: check class properties iterator Marc-André Lureau
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 10/12] vl: handle -object help Marc-André Lureau
2018-10-05 12:29 ` Marc-André Lureau [this message]
2018-10-05 12:29 ` [Qemu-devel] [PULL v2 12/12] vl: list user creatable properties when 'help' is argument Marc-André Lureau
2018-10-08 10:10 ` [Qemu-devel] [PULL v2 00/12] Option patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181005122910.11745-12-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).