From: Kevin Wolf <kwolf@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>, Qemu-block <qemu-block@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain
Date: Fri, 5 Oct 2018 20:09:01 +0200 [thread overview]
Message-ID: <20181005180901.GA32677@localhost.localdomain> (raw)
In-Reply-To: <CAFEAcA-SWRHwnwsa+QiHXfdBRB6u2u0paV9HsEqfjR6nZvAHSg@mail.gmail.com>
Am 05.10.2018 um 18:54 hat Peter Maydell geschrieben:
> On 5 October 2018 at 17:17, Kevin Wolf <kwolf@redhat.com> wrote:
> > Am 05.10.2018 um 16:41 hat Peter Maydell geschrieben:
> >> On 5 October 2018 at 15:38, Peter Maydell <peter.maydell@linaro.org> wrote:
> >> > The test-bdrv-drain test fails at least 50% of the time
> >> > on my OS build system. Disable the test until we can figure
> >>
> >> This is a typo: I meant "OSX build system".
> >>
> >> > out what's going on, as this makes pull request processing
> >> > very difficult.
> >> >
> >> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > Can we disable it conditionally only on OS X instead?
> >
> > I'd hate to lose this test case, and without OS X I can't really do
> > anything to fix the problem (or to even find out if it's a test case
> > problem or a bug that the test case reveals).
>
> If we disable it for OSX only then nobody has any incentive
> to investigate and fix it...
And if we disable it wholesale, then nobody has any incentive to fix any
bug that the test case could have uncovered.
Look, if this were on BSD or something, I'd even setup a BSD VM and try
to investigate. With OS X, that's not an option. If OS X users care
about the bug, they need to fix it. If you want to give them an
incentive, then the test case needs to stay enabled. If they don't care,
we can disable the test case for OS X (and leave QEMU broken if it's a
real bug, but eventually someone will certainly report a bug in a real
life scenario in that case).
Anyway, killing tests for Linux users because they can't fix OS X bugs
doesn't sound like a very useful policy to me.
Kevin
next prev parent reply other threads:[~2018-10-05 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 14:38 [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain Peter Maydell
2018-10-05 14:41 ` Peter Maydell
2018-10-05 16:17 ` Kevin Wolf
2018-10-05 16:54 ` Peter Maydell
2018-10-05 18:09 ` Kevin Wolf [this message]
2018-10-08 9:12 ` Peter Maydell
2018-10-08 15:43 ` Peter Maydell
2018-10-08 16:40 ` Kevin Wolf
2018-10-08 17:07 ` Peter Maydell
2018-10-08 19:53 ` Eric Blake
2018-10-09 9:48 ` Kevin Wolf
2018-10-09 11:16 ` Paolo Bonzini
2018-11-02 13:33 ` Peter Maydell
2018-11-04 22:03 ` Paolo Bonzini
2018-11-05 10:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005180901.GA32677@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).