From: Bishara AbuHattoum <bishara@daynix.com>
To: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Yan Vugenfirer <yan@daynix.com>, Sameeh Jubran <sameeh@daynix.com>
Subject: [Qemu-devel] [PATCH v2 5/7] qga-win: install service with --retry-path set by default
Date: Sun, 7 Oct 2018 14:02:21 +0300 [thread overview]
Message-ID: <20181007110223.129692-6-bishara@daynix.com> (raw)
In-Reply-To: <20181007110223.129692-1-bishara@daynix.com>
From: Michael Roth <mdroth@linux.vnet.ibm.com>
It's nicer from a management perspective that the agent can survive
hotplug/unplug of the channel device, or be started prior to the
installation of the channel device's driver without and still be able
to resume normal function afterward. On linux there are alternatives
like systemd to support this, but on w32 --retry-path is the only
option so it makes sense to set it by default when installed as a
w32 service.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index f751a7e9f7..64bf90bd85 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga/installer/qemu-ga.wxs
@@ -78,7 +78,7 @@
Account="LocalSystem"
ErrorControl="ignore"
Interactive="no"
- Arguments="-d"
+ Arguments="-d --retry-path"
>
</ServiceInstall>
<ServiceControl Id="StartService" Start="install" Stop="both" Remove="uninstall" Name="QEMU-GA" Wait="no" />
--
2.17.0
next prev parent reply other threads:[~2018-10-07 11:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 11:02 [Qemu-devel] [PATCH v2 0/7] qga: add support for re-opening channel on error Bishara AbuHattoum
2018-10-07 11:02 ` [Qemu-devel] [PATCH v2 1/7] qga: group agent init/cleanup init separate routines Bishara AbuHattoum
2018-10-07 11:02 ` [Qemu-devel] [PATCH v2 2/7] qga: hang GAConfig/socket_activation off of GAState global Bishara AbuHattoum
2018-10-07 11:02 ` [Qemu-devel] [PATCH v2 3/7] qga: move w32 service handling out of run_agent() Bishara AbuHattoum
2018-10-07 11:02 ` [Qemu-devel] [PATCH v2 4/7] qga: add --retry-path option for re-initializing channel on failure Bishara AbuHattoum
2018-10-07 11:02 ` Bishara AbuHattoum [this message]
2018-10-07 11:02 ` [Qemu-devel] [PATCH v2 6/7] qga-win: report specific error when failing to open channel Bishara AbuHattoum
2018-10-07 11:02 ` [Qemu-devel] [PATCH v2 7/7] qga-win: changing --retry-path option behavior Bishara AbuHattoum
2018-10-30 14:32 ` [Qemu-devel] [PATCH v2 0/7] qga: add support for re-opening channel on error Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007110223.129692-6-bishara@daynix.com \
--to=bishara@daynix.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sameeh@daynix.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).