From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9LS9-00061f-Go for qemu-devel@nongnu.org; Sun, 07 Oct 2018 22:39:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9LRH-0003Ci-P6 for qemu-devel@nongnu.org; Sun, 07 Oct 2018 22:38:32 -0400 Date: Mon, 8 Oct 2018 10:38:22 +0800 From: Fam Zheng Message-ID: <20181008023523.GA13536@magic> References: <20180913082952.3675-1-yuchenlin@synology.com> <20180913083449.GQ2526@lemon.usersys.redhat.com> <4e0dfed2afdc5a551f37ecbcbf5f4ade@synology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e0dfed2afdc5a551f37ecbcbf5f4ade@synology.com> Subject: Re: [Qemu-devel] [PATCH v3] vmdk: align end of file to a sector boundary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: yuchenlin Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org On Fri, 10/05 10:00, yuchenlin wrote: > Ping? Hi, This was merged as 51b3c6b73acae1e3fd3c7d441fc86dd17356695f. Fam > > On 2018-09-13 16:34, Fam Zheng wrote: > > On Thu, 09/13 16:29, yuchenlin@synology.com wrote: > > > From: yuchenlin > > > > > > There is a rare case which the size of last compressed cluster > > > is larger than the cluster size, which will cause the file is > > > not aligned at the sector boundary. > > > > > > There are three reasons to do it. First, if vmdk doesn't align at > > > the sector boundary, there may be many undefined behaviors, > > > such as, in vbox it will show VMDK: Compressed image is corrupted > > > 'syno-vm-disk1.vmdk' (VERR_ZIP_CORRUPTED) when we try to import an > > > ova with unaligned vmdk. Second, all the cluster_sector is aligned > > > to sector, the last one should be like this, too. Third, it ease > > > reading with sector based I/Os. > > > > > > Signed-off-by: yuchenlin > > > > Reviewed-by: Fam Zheng >