* [Qemu-devel] [PATCH] qemu-io-cmds: Fix two format strings
@ 2018-10-06 18:38 Stefan Weil
2018-10-07 17:29 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2018-10-08 9:10 ` [Qemu-devel] " Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2018-10-06 18:38 UTC (permalink / raw)
To: QEMU Developer
Cc: QEMU Trivial, Kevin Wolf, Max Reitz, qemu-block, Stefan Weil
Use %zu instead of %zd for unsigned numbers.
This fixes two error messages from the LSTM static code analyzer:
This argument should be of type 'ssize_t' but is of type 'unsigned long'
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
qemu-io-cmds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index db0b3ee5ef..5363482213 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -907,7 +907,7 @@ static int readv_f(BlockBackend *blk, int argc, char **argv)
memset(cmp_buf, pattern, qiov.size);
if (memcmp(buf, cmp_buf, qiov.size)) {
printf("Pattern verification failed at offset %"
- PRId64 ", %zd bytes\n", offset, qiov.size);
+ PRId64 ", %zu bytes\n", offset, qiov.size);
ret = -EINVAL;
}
g_free(cmp_buf);
@@ -1294,7 +1294,7 @@ static void aio_read_done(void *opaque, int ret)
memset(cmp_buf, ctx->pattern, ctx->qiov.size);
if (memcmp(ctx->buf, cmp_buf, ctx->qiov.size)) {
printf("Pattern verification failed at offset %"
- PRId64 ", %zd bytes\n", ctx->offset, ctx->qiov.size);
+ PRId64 ", %zu bytes\n", ctx->offset, ctx->qiov.size);
}
g_free(cmp_buf);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-io-cmds: Fix two format strings
2018-10-06 18:38 [Qemu-devel] [PATCH] qemu-io-cmds: Fix two format strings Stefan Weil
@ 2018-10-07 17:29 ` Philippe Mathieu-Daudé
2018-10-08 9:10 ` [Qemu-devel] " Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-07 17:29 UTC (permalink / raw)
To: Stefan Weil, QEMU Developer
Cc: QEMU Trivial, Kevin Wolf, qemu-block, Max Reitz
On 10/6/18 8:38 PM, Stefan Weil wrote:
> Use %zu instead of %zd for unsigned numbers.
>
> This fixes two error messages from the LSTM static code analyzer:
>
> This argument should be of type 'ssize_t' but is of type 'unsigned long'
Eventually prepend some spaces to have the difference between your
statement and the analyzer output.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> qemu-io-cmds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index db0b3ee5ef..5363482213 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -907,7 +907,7 @@ static int readv_f(BlockBackend *blk, int argc, char **argv)
> memset(cmp_buf, pattern, qiov.size);
> if (memcmp(buf, cmp_buf, qiov.size)) {
> printf("Pattern verification failed at offset %"
> - PRId64 ", %zd bytes\n", offset, qiov.size);
> + PRId64 ", %zu bytes\n", offset, qiov.size);
> ret = -EINVAL;
> }
> g_free(cmp_buf);
> @@ -1294,7 +1294,7 @@ static void aio_read_done(void *opaque, int ret)
> memset(cmp_buf, ctx->pattern, ctx->qiov.size);
> if (memcmp(ctx->buf, cmp_buf, ctx->qiov.size)) {
> printf("Pattern verification failed at offset %"
> - PRId64 ", %zd bytes\n", ctx->offset, ctx->qiov.size);
> + PRId64 ", %zu bytes\n", ctx->offset, ctx->qiov.size);
> }
> g_free(cmp_buf);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-io-cmds: Fix two format strings
2018-10-06 18:38 [Qemu-devel] [PATCH] qemu-io-cmds: Fix two format strings Stefan Weil
2018-10-07 17:29 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
@ 2018-10-08 9:10 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2018-10-08 9:10 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Developer, QEMU Trivial, Max Reitz, qemu-block
Am 06.10.2018 um 20:38 hat Stefan Weil geschrieben:
> Use %zu instead of %zd for unsigned numbers.
>
> This fixes two error messages from the LSTM static code analyzer:
>
> This argument should be of type 'ssize_t' but is of type 'unsigned long'
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-08 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-06 18:38 [Qemu-devel] [PATCH] qemu-io-cmds: Fix two format strings Stefan Weil
2018-10-07 17:29 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2018-10-08 9:10 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).