qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Sameeh Jubran <sameeh@daynix.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Hotplug handler
Date: Mon, 8 Oct 2018 10:28:46 +0200	[thread overview]
Message-ID: <20181008102846.3ce9c912@redhat.com> (raw)
In-Reply-To: <CAKPgXcF575pf+dizFKjV1PrQo6tfbdwd+AA72a=kbcxdTcKCmA@mail.gmail.com>

On Sun, 7 Oct 2018 12:52:11 +0300
Sameeh Jubran <sameeh@daynix.com> wrote:

> This is the command line. All of the devices are wired to pci.0, there is
> no pci bridge.
> 
> According to this,  Integrated Endpoints are not hot-pluggable. However I
> can still use device_del to delete a device and device_add to add e1000
> with no issues.
> https://github.com/qemu/qemu/blob/master/docs/pcie.txt#L37
Your CLI is using default 'pc' machine so it's conventional PCI (not PCI-E),
with that CLI for a device plugged into pci.0 bus you should get piix4_pm as
hotplug handler (ACPI is used on pci.0 as default).
To troubleshoot your issue, you might look at code that's
using following symbols:

  use_acpi_pci_hotplug
  piix4_update_bus_hotplug
  piix4_device_plug_cb
  piix4_device_unplug_request_cb

> 
> qemu-system-x86_64 \
> -device
> e1000,netdev=hostnet0,mac=56:cc:c1:01:cc:21,id=cc1_71,primary=cc1_72 \
> -netdev
> tap,vhost=on,id=hostnet1,script=world_bridge_standalone.sh,downscript=no,ifname=cc1_72,queues=4
> \
> -device
> virtio-net,host_mtu=1500,netdev=hostnet1,mac=56:cc:c1:04:2c:21,id=cc1_72,vectors=10,mq=on,standby=cc1_71
> \
> -netdev
> tap,id=hostnet0,script=world_bridge_standalone.sh,downscript=no,ifname=cc1_71
> \
> -enable-kvm \
> -name netkvm \
> -m 1000M \
> -snapshot \
> -smp 4 \
> -drive file=windows_10_enterprise_x64_netkvm_dev.qcow2,if=ide,id=drivex \
> -global PIIX4_PM.disable_s3=0 \
> -global PIIX4_PM.disable_s4=0 \
> -usbdevice tablet \
> -vga qxl \
> -spice port=6110,disable-ticketing \
> -device virtio-serial-pci,id=virtio-serial0,max_ports=16,bus=pci.0,addr=0x7
> \
> -chardev spicevmc,name=vdagent,id=vdagent \
> -device
> virtserialport,nr=1,bus=virtio-serial0.0,chardev=vdagent,name=com.redhat.spice.0
> \
> -chardev socket,path=/tmp/qga.sock,server,nowait,id=qga0 \
> -device virtio-serial \
> -device virtserialport,chardev=qga0,name=org.qemu.guest_agent.0 \
> -monitor stdio
> 
> 
> On Thu, Oct 4, 2018 at 2:20 PM Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > On Wed, 3 Oct 2018 19:50:58 +0300
> > Sameeh Jubran <sameeh@daynix.com> wrote:
> >  
> > > Hi all,
> > >
> > > I am trying to get the hotplug handler of a pci device in Qemu using
> > > "qdev_get_hotplug_handler" function. This function simply tries to get
> > > the hotplug handler from the parent bus. For some reason it's always
> > > null. Why it is not initialized?
> > >
> > > Thanks!
> > >  
> >
> > what's used qemu command line?
> >  
> 
> 

  reply	other threads:[~2018-10-08  8:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 16:50 [Qemu-devel] Hotplug handler Sameeh Jubran
2018-10-04 11:20 ` Igor Mammedov
2018-10-07  9:52   ` Sameeh Jubran
2018-10-08  8:28     ` Igor Mammedov [this message]
2018-10-08 10:44       ` Sameeh Jubran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008102846.3ce9c912@redhat.com \
    --to=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sameeh@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).