From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target/s390x/excp_helper: Remove DPRINTF() macro
Date: Mon, 8 Oct 2018 12:01:30 +0200 [thread overview]
Message-ID: <20181008120130.3f84d6f8.cohuck@redhat.com> (raw)
In-Reply-To: <1538751601-7433-1-git-send-email-thuth@redhat.com>
On Fri, 5 Oct 2018 17:00:01 +0200
Thomas Huth <thuth@redhat.com> wrote:
> Debug macros that are disabled by default should be avoided (since the
> code bit-rots quite easily). Thus turn these debug prints into proper
> qemu_log_mask(CPU_LOG_xxx, ...) statements instead. The DPRINTF statements
> in do_[ext|io|mchk]_interrupt can even be removed completely since we can
> log the information in a central place, s390_cpu_do_interrupt, instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/s390x/excp_helper.c | 48 +++++++++++-----------------------------------
> 1 file changed, 11 insertions(+), 37 deletions(-)
[patch had gained a trivial-to-fix contextual conflict in the
meanwhile; fixed]
Thanks, applied.
prev parent reply other threads:[~2018-10-08 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 15:00 [Qemu-devel] [PATCH] target/s390x/excp_helper: Remove DPRINTF() macro Thomas Huth
2018-10-08 8:46 ` David Hildenbrand
2018-10-08 10:01 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008120130.3f84d6f8.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).