From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9itR-0006IC-Tk for qemu-devel@nongnu.org; Mon, 08 Oct 2018 23:41:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9idN-0006Lf-Tb for qemu-devel@nongnu.org; Mon, 08 Oct 2018 23:24:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9idN-0006E2-NP for qemu-devel@nongnu.org; Mon, 08 Oct 2018 23:24:33 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58084309178E for ; Tue, 9 Oct 2018 03:24:32 +0000 (UTC) Date: Tue, 9 Oct 2018 11:24:28 +0800 From: Peter Xu Message-ID: <20181009032428.GJ18728@xz-x1> References: <20181008173125.19678-1-armbru@redhat.com> <20181008173125.19678-10-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181008173125.19678-10-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 09/31] ioapic: Fix error handling in realize() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On Mon, Oct 08, 2018 at 07:31:03PM +0200, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. ioapic_realize() does that, and then exit()s. > Currently mostly harmless, as the device cannot be hot-plugged. > > Fixes: 20fd4b7b6d9282fe0cb83601f1821f31bd257458 > Cc: Peter Xu > Signed-off-by: Markus Armbruster Reviewed-by: Peter Xu -- Peter Xu