From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com
Subject: [Qemu-devel] [PATCH v9 6/6] tests: qmp-test: add queue full test
Date: Tue, 9 Oct 2018 14:27:18 +0800 [thread overview]
Message-ID: <20181009062718.1914-7-peterx@redhat.com> (raw)
In-Reply-To: <20181009062718.1914-1-peterx@redhat.com>
We'll need to include "monitor/monitor.h" for the queue length macro,
then we don't need to hard code it.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qmp-test.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index cc9907b525..6989acbca4 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -18,6 +18,7 @@
#include "qapi/qmp/qlist.h"
#include "qapi/qobject-input-visitor.h"
#include "qapi/qmp/qstring.h"
+#include "monitor/monitor.h"
const char common_args[] = "-nodefaults -machine none";
@@ -218,6 +219,8 @@ static void test_qmp_oob(void)
const QListEntry *entry;
QList *capabilities;
QString *qstr;
+ gchar *id;
+ int i;
qts = qtest_init_without_qmp_handshake(common_args);
@@ -272,6 +275,29 @@ static void test_qmp_oob(void)
unblock_blocked_cmd();
recv_cmd_id(qts, "blocks-2");
recv_cmd_id(qts, "err-2");
+
+ /*
+ * Test queue full. When that happens, the out-of-band command
+ * will only be able to be handled after the queue is shrinked, so
+ * it'll be processed only after one existing in-band command
+ * finishes.
+ */
+ for (i = 1; i <= QMP_REQ_QUEUE_LEN_MAX; i++) {
+ id = g_strdup_printf("queue-blocks-%d", i);
+ send_cmd_that_blocks(qts, id);
+ g_free(id);
+ }
+ send_oob_cmd_that_fails(qts, "oob-1");
+ unblock_blocked_cmd();
+ recv_cmd_id(qts, "queue-blocks-1");
+ recv_cmd_id(qts, "oob-1");
+ for (i = 2; i <= QMP_REQ_QUEUE_LEN_MAX; i++) {
+ unblock_blocked_cmd();
+ id = g_strdup_printf("queue-blocks-%d", i);
+ recv_cmd_id(qts, id);
+ g_free(id);
+ }
+
cleanup_blocking_cmd();
qtest_quit(qts);
--
2.17.1
next prev parent reply other threads:[~2018-10-09 6:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 6:27 [Qemu-devel] [PATCH v9 0/6] monitor: enable OOB by default Peter Xu
2018-10-09 6:27 ` [Qemu-devel] [PATCH v9 1/6] monitor: Suspend monitor instead dropping commands Peter Xu
2018-10-31 14:01 ` Markus Armbruster
2018-10-09 6:27 ` [Qemu-devel] [PATCH v9 2/6] monitor: resume the monitor earlier if needed Peter Xu
2018-10-09 8:54 ` Marc-André Lureau
2018-10-10 3:21 ` Peter Xu
2018-10-29 11:10 ` Marc-André Lureau
2018-10-09 6:27 ` [Qemu-devel] [PATCH v9 3/6] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-10-09 6:27 ` [Qemu-devel] [PATCH v9 4/6] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-10-09 6:27 ` [Qemu-devel] [PATCH v9 5/6] tests: add oob functional test for test-qmp-cmds Peter Xu
2018-10-09 6:27 ` Peter Xu [this message]
2018-10-10 16:26 ` [Qemu-devel] [PATCH v9 0/6] monitor: enable OOB by default Eric Blake
2018-10-10 19:26 ` Eric Blake
2018-10-10 20:27 ` Eric Blake
2018-10-11 0:05 ` Peter Xu
2018-10-11 1:17 ` Eric Blake
2018-10-11 2:26 ` Peter Xu
2018-10-31 13:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009062718.1914-7-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).