From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9s1Z-0007NP-SG for qemu-devel@nongnu.org; Tue, 09 Oct 2018 09:26:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9s1T-0007ul-1R for qemu-devel@nongnu.org; Tue, 09 Oct 2018 09:26:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48238) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9s1O-0007hG-Sr for qemu-devel@nongnu.org; Tue, 09 Oct 2018 09:26:00 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2D17730842AE for ; Tue, 9 Oct 2018 13:25:56 +0000 (UTC) Date: Tue, 9 Oct 2018 14:25:52 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20181009132552.GD22838@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20181008173125.19678-1-armbru@redhat.com> <20181008173125.19678-19-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181008173125.19678-19-armbru@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 18/31] qom: Clean up error reporting in user_creatable_add_opts_foreach() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On Mon, Oct 08, 2018 at 07:31:12PM +0200, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. user_creatable_add_opts_foreach() does that, and then > fails without setting an error. Its caller main(), via > qemu_opts_foreach(), is fine with it, but clean it up anyway. >=20 > Cc: Daniel P. Berrang=C3=A9 > Signed-off-by: Markus Armbruster > --- > qemu-io.c | 8 +++----- > qemu-nbd.c | 8 +++----- > qom/object_interfaces.c | 4 +--- > vl.c | 16 ++++++---------- > 4 files changed, 13 insertions(+), 23 deletions(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|