From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: crosa@redhat.com, ehabkost@redhat.com, eblake@redhat.com,
armbru@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
vsementsov@virtuozzo.com, den@openvz.org
Subject: [Qemu-devel] [PATCH v4 0/3] block nodes graph visualization
Date: Tue, 9 Oct 2018 18:00:03 +0300 [thread overview]
Message-ID: <20181009150006.10712-1-vsementsov@virtuozzo.com> (raw)
Hi all!
On the way of backup schemes development (and in general any complicated
developments in Qemu block layer) it would be good to have an ability to print
out graph of block nodes with their permissions.
v4:
01: - improve documentation and graph node type names
- parentheses in macro
- s/hash/graph_nodes
- add dbg_ prefix to graph functions
- free leaked gr in dbg_graph_finalize()
- use uintptr_t and "!= 0" for hash keys, add comment
about reserved 0 key
- add const specifier for permissions array and iterator,
add static on permissions array size
- fall back to blk_get_attached_dev_id() for block-backend
nodes if blk_name() returns NULL
02: - add a-b by Eduardo and r-b by Max
- change graph node type names (rebase on 01 change)
v3: again, major rework, after long discussion with Max:
- start creating graph looping through blk's and block jobs, don't use opaque
- don't export pointers, generate ids instead
(graphical representation didn't significantly changed, you can look at the
picture, attached to v2 cover-letter)
v2: major rework: Identifying non-bds nodes by their description was a bad idea,
descriptions are not guaranteed to be different for different nodes. So, the only
way is use pointer to identify them. And to be unique, let's use pointers to
identify all the nodes in the graph. As additional benefit, we have pointers for
each node, which is good for debugging (imagine a gdb session).
Vladimir Sementsov-Ogievskiy (3):
qapi: add x-debug-query-block-graph
scripts: add render_block_graph function for QEMUMachine
not-for-commit: example of new command usage for debugging
qapi/block-core.json | 108 ++++++++++++++++++++++++
include/block/block.h | 1 +
include/sysemu/block-backend.h | 2 +
block.c | 146 +++++++++++++++++++++++++++++++++
block/block-backend.c | 5 ++
blockdev.c | 5 ++
scripts/render_block_graph.py | 120 +++++++++++++++++++++++++++
tests/qemu-iotests/222 | 2 +
8 files changed, 389 insertions(+)
create mode 100755 scripts/render_block_graph.py
--
2.18.0
next reply other threads:[~2018-10-09 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 15:00 Vladimir Sementsov-Ogievskiy [this message]
2018-10-09 15:00 ` [Qemu-devel] [PATCH v4 1/3] qapi: add x-debug-query-block-graph Vladimir Sementsov-Ogievskiy
2018-10-13 13:55 ` Max Reitz
2018-10-09 15:00 ` [Qemu-devel] [PATCH v4 2/3] scripts: add render_block_graph function for QEMUMachine Vladimir Sementsov-Ogievskiy
2018-10-09 15:00 ` [Qemu-devel] [PATCH v4 3/3] not-for-commit: example of new command usage for debugging Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009150006.10712-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).