From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
Eduardo Habkost <ehabkost@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v1 5/7] memory-device: use QEMU_IS_ALIGNED
Date: Tue, 9 Oct 2018 22:56:50 +0200 [thread overview]
Message-ID: <20181009205652.10605-6-david@redhat.com> (raw)
In-Reply-To: <20181009205652.10605-1-david@redhat.com>
Shorter and easier to read.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/mem/memory-device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 7de1ccd497..996ad1490f 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -120,7 +120,7 @@ static uint64_t memory_device_get_free_addr(MachineState *ms,
g_assert(address_space_end >= address_space_start);
/* address_space_start indicates the maximum alignment we expect */
- if (QEMU_ALIGN_UP(address_space_start, align) != address_space_start) {
+ if (!QEMU_IS_ALIGNED(address_space_start, align)) {
error_setg(errp, "the alignment (0x%" PRIx64 ") is not supported",
align);
return 0;
@@ -131,13 +131,13 @@ static uint64_t memory_device_get_free_addr(MachineState *ms,
return 0;
}
- if (hint && QEMU_ALIGN_UP(*hint, align) != *hint) {
+ if (hint && !QEMU_IS_ALIGNED(*hint, align)) {
error_setg(errp, "address must be aligned to 0x%" PRIx64 " bytes",
align);
return 0;
}
- if (QEMU_ALIGN_UP(size, align) != size) {
+ if (!QEMU_IS_ALIGNED(size, align)) {
error_setg(errp, "backend memory size must be multiple of 0x%"
PRIx64, align);
return 0;
--
2.17.1
next prev parent reply other threads:[~2018-10-09 20:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 20:56 [Qemu-devel] [PATCH v1 0/7] qapi/range/memory-device: fixes and cleanups David Hildenbrand
2018-10-09 20:56 ` [Qemu-devel] [PATCH v1 1/7] qapi: correctly parse uint64_t values from strings David Hildenbrand
2018-10-09 20:56 ` [Qemu-devel] [PATCH v1 2/7] qapi: use qemu_strtoi64() in parse_str_int64 David Hildenbrand
2018-10-09 20:56 ` [Qemu-devel] [PATCH v1 3/7] range: pass const pointer where possible David Hildenbrand
2018-10-11 8:39 ` Dr. David Alan Gilbert
2018-10-09 20:56 ` [Qemu-devel] [PATCH v1 4/7] range: add some more functions David Hildenbrand
2018-10-11 9:08 ` Dr. David Alan Gilbert
2018-10-11 9:10 ` David Hildenbrand
2018-10-11 9:21 ` Dr. David Alan Gilbert
2018-10-11 9:27 ` David Hildenbrand
2018-10-11 10:27 ` Dr. David Alan Gilbert
2018-10-11 10:28 ` David Hildenbrand
2018-10-09 20:56 ` David Hildenbrand [this message]
2018-10-11 8:47 ` [Qemu-devel] [PATCH v1 5/7] memory-device: use QEMU_IS_ALIGNED Dr. David Alan Gilbert
2018-10-09 20:56 ` [Qemu-devel] [PATCH v1 6/7] memory-device: avoid overflows on very huge devices David Hildenbrand
2018-10-09 20:56 ` [Qemu-devel] [PATCH v1 7/7] memory-device: rewrite address assignment using ranges David Hildenbrand
2018-10-11 10:20 ` Dr. David Alan Gilbert
2018-10-11 10:26 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009205652.10605-6-david@redhat.com \
--to=david@redhat.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).