From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Fam Zheng" <famz@redhat.com>,
"Philippe Mathieu-Daudé" <pmathieu@redhat.com>,
"Caio Carrara" <ccarrara@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/7] Acceptance Tests: improve docstring on pick_default_qemu_bin()
Date: Tue, 9 Oct 2018 19:26:01 -0400 [thread overview]
Message-ID: <20181009232607.15521-2-crosa@redhat.com> (raw)
In-Reply-To: <20181009232607.15521-1-crosa@redhat.com>
Making it clear what is returned by this utility function.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/acceptance/avocado_qemu/__init__.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index 1e54fd5932..d8d5b48dac 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -27,6 +27,10 @@ def pick_default_qemu_bin():
"""
Picks the path of a QEMU binary, starting either in the current working
directory or in the source tree root directory.
+
+ :returns: the path to the default QEMU binary or None if one could not
+ be found
+ :rtype: str or None
"""
arch = os.uname()[4]
qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
--
2.17.1
next prev parent reply other threads:[~2018-10-09 23:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 23:26 [Qemu-devel] [PATCH v2 0/7] Acceptance Tests: basic architecture support Cleber Rosa
2018-10-09 23:26 ` Cleber Rosa [this message]
2018-10-09 23:26 ` [Qemu-devel] [PATCH v2 2/7] Acceptance Tests: introduce arch parameter and attribute Cleber Rosa
2018-10-10 11:03 ` Philippe Mathieu-Daudé
2018-10-09 23:26 ` [Qemu-devel] [PATCH v2 3/7] scripts/qemu.py: add method and private attribute for arch Cleber Rosa
2018-10-10 10:52 ` Philippe Mathieu-Daudé
2018-10-09 23:26 ` [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch Cleber Rosa
2018-10-10 11:00 ` Philippe Mathieu-Daudé
2018-10-10 12:35 ` Cleber Rosa
2018-10-10 13:46 ` Eduardo Habkost
2018-10-10 13:59 ` Cleber Rosa
2018-10-10 14:15 ` Cleber Rosa
2018-10-10 14:28 ` Eduardo Habkost
2018-10-10 15:26 ` Philippe Mathieu-Daudé
2018-10-10 15:58 ` Cleber Rosa
2018-10-10 16:08 ` Philippe Mathieu-Daudé
2018-10-10 18:08 ` Cleber Rosa
2018-10-10 15:31 ` Daniel P. Berrangé
2018-10-10 16:02 ` Cleber Rosa
2018-10-10 15:47 ` Cleber Rosa
2018-10-10 16:23 ` Peter Maydell
2018-10-10 17:52 ` Cleber Rosa
2018-10-10 18:07 ` Peter Maydell
2018-10-10 19:54 ` Cleber Rosa
2018-10-11 17:31 ` Peter Maydell
2018-10-11 0:17 ` Cleber Rosa
2018-10-11 3:42 ` Eduardo Habkost
2018-10-11 4:43 ` Cleber Rosa
2018-10-11 17:21 ` Eduardo Habkost
2018-10-09 23:26 ` [Qemu-devel] [PATCH v2 5/7] Acceptance Tests: set machine type Cleber Rosa
2018-10-09 23:26 ` [Qemu-devel] [PATCH v2 6/7] Acceptance Tests: add variants definition for architectures Cleber Rosa
2018-10-10 10:51 ` Philippe Mathieu-Daudé
2018-10-10 12:59 ` Cleber Rosa
2018-10-10 10:59 ` Philippe Mathieu-Daudé
2018-10-10 12:48 ` Cleber Rosa
2018-10-09 23:26 ` [Qemu-devel] [PATCH v2 7/7] Acceptance Tests: change the handling of tests for specific archs Cleber Rosa
2018-10-10 10:50 ` Philippe Mathieu-Daudé
2018-10-10 13:09 ` Cleber Rosa
2018-10-13 11:08 ` Philippe Mathieu-Daudé
2018-10-15 13:52 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009232607.15521-2-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ccarrara@redhat.com \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=lersek@redhat.com \
--cc=pmathieu@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).