From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, war2jordan@live.com,
pavel.dovgaluk@ispras.ru, mst@redhat.com, jasowang@redhat.com,
zuban32s@gmail.com, kraxel@redhat.com,
thomas.dullien@googlemail.com, artem.k.pisarenko@gmail.com,
quintela@redhat.com, ciro.santilli@gmail.com,
armbru@redhat.comdovgaluk@ispras.ru, dgilbert@redhat.com,
boost.lists@gmail.com, alex.bennee@linaro.org, rth@twiddle.net,
kwolf@redhat.com, crosthwaite.peter@gmail.com, mreitz@redhat.com,
maria.klimushenkova@ispras.ru, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v7 19/19] replay: document development rules
Date: Wed, 10 Oct 2018 16:35:22 +0300 [thread overview]
Message-ID: <20181010133522.24538.48800.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20181010133333.24538.53169.stgit@pasha-VirtualBox>
This patch introduces docs/devel/replay.txt which describes the rules
that should be followed to make virtual devices usable in record/replay mode.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgauk@ispras.ru>
---
docs/devel/replay.txt | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 docs/devel/replay.txt
diff --git a/docs/devel/replay.txt b/docs/devel/replay.txt
new file mode 100644
index 0000000..61dac1b
--- /dev/null
+++ b/docs/devel/replay.txt
@@ -0,0 +1,45 @@
+Record/replay mechanism, that could be enabled through icount mode, expects
+the virtual devices to satisfy the following requirements.
+
+The main idea behind this document is that everything that affects
+the guest state during execution in icount mode should be deterministic.
+
+Timers
+======
+
+All virtual devices should use virtual clock for timers that change the guest
+state. Virtual clock is deterministic, therefore such timers are deterministic
+too.
+
+Virtual devices can also use realtime clock for the events that do not change
+the guest state directly. When the clock ticking should depend on VM execution
+speed, use virtual ext clock. It is not deterministic, but its speed depends
+on the guest execution. This clock is used by the virtual devices (e.g.,
+slirp routing device) that lie outside the replayed guest.
+
+Bottom halves
+=============
+
+Bottom half callbacks, that affect the guest state, should be invoked through
+replay_bh_schedule_event or replay_bh_schedule_oneshot_event functions.
+Their invocations are saved in record mode and synchronized with the existing
+log in replay mode.
+
+Saving/restoring the VM state
+=============================
+
+All fields in the device state structure (including virtual timers)
+should be restored by loadvm to the same values they had before savevm.
+
+Avoid accessing other devices' state, because the order of saving/restoring
+is not defined. It means that you should not call functions like
+'update_irq' in post_load callback. Save everything explicitly to avoid
+the dependencies that may make restoring the VM state non-deterministic.
+
+Stopping the VM
+===============
+
+Stopping the guest should not interfere with its state (with the exception
+of the network connections, that could be broken by the remote timeouts).
+VM can be stopped at any moment of replay by the user. Restarting the VM
+after that stop should not break the replay by the unneeded guest state change.
next prev parent reply other threads:[~2018-10-10 13:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 13:33 [Qemu-devel] [PATCH v7 00/19] Fixing record/replay and adding reverse debugging Pavel Dovgalyuk
2018-10-10 13:33 ` [Qemu-devel] [PATCH v7 01/19] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-10-10 13:33 ` [Qemu-devel] [PATCH v7 02/19] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-10-10 13:33 ` [Qemu-devel] [PATCH v7 03/19] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2018-10-10 13:33 ` [Qemu-devel] [PATCH v7 04/19] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2018-11-28 15:45 ` Kevin Wolf
2018-11-30 7:55 ` Pavel Dovgalyuk
2018-11-30 10:01 ` Kevin Wolf
2018-11-30 10:51 ` Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 05/19] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 06/19] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2018-11-28 14:33 ` Kevin Wolf
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 07/19] migration: " Pavel Dovgalyuk
2018-11-28 15:53 ` Kevin Wolf
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 08/19] replay: provide and accessor for rr filename Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 09/19] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 10/19] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 11/19] replay: implement replay-seek command to proceed to the desired step Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 12/19] replay: refine replay-time module Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 13/19] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 14/19] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2018-10-10 13:34 ` [Qemu-devel] [PATCH v7 15/19] gdbstub: add reverse continue " Pavel Dovgalyuk
2018-10-10 13:35 ` [Qemu-devel] [PATCH v7 16/19] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2018-10-10 13:35 ` [Qemu-devel] [PATCH v7 17/19] replay: add BH oneshot event for block layer Pavel Dovgalyuk
2018-11-28 16:01 ` Kevin Wolf
2018-11-30 8:21 ` Pavel Dovgalyuk
2018-11-30 11:18 ` Kevin Wolf
2018-11-30 11:26 ` Pavel Dovgalyuk
2018-10-10 13:35 ` [Qemu-devel] [PATCH v7 18/19] replay: init rtc after enabling the replay Pavel Dovgalyuk
2018-10-11 13:48 ` Artem Pisarenko
2018-10-10 13:35 ` Pavel Dovgalyuk [this message]
2018-10-11 15:08 ` [Qemu-devel] [PATCH v7 19/19] replay: document development rules Artem Pisarenko
2018-10-10 15:58 ` [Qemu-devel] [PATCH v7 00/19] Fixing record/replay and adding reverse debugging Aleksandr Bezzubikov
2018-10-15 8:46 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010133522.24538.48800.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=armbru@redhat.comdovgaluk \
--cc=artem.k.pisarenko@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thomas.dullien@googlemail.com \
--cc=war2jordan@live.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).