From: Peter Xu <peterx@redhat.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] delay monitor iothread creation
Date: Thu, 11 Oct 2018 08:09:33 +0800 [thread overview]
Message-ID: <20181011000933.GB5014@xz-x1> (raw)
In-Reply-To: <20180928075832.18586-1-w.bumiller@proxmox.com>
On Fri, Sep 28, 2018 at 09:58:30AM +0200, Wolfgang Bumiller wrote:
> The early monitor iothread creation conflicts with the -daemonize option
> causing crashes at shutdown of a daemonized qemu instance.
> These patches will delay the creation to when a monitor using it is
> actually spawned.
>
> While the second patch depends on the first one, the first is a
> consistency cleanup on its own, therefore split out.
>
> v2:
> This version incorporates Markus Armbruster's requested change to
> protect mon_iothread initialization by monitor_lock (and moves the
> variable declaration to reflect this), and adds a comments about
> monitor_init() expecting to be run in the main thread.
>
> Wolfgang Bumiller (2):
> monitor: guard iothread access by mon->use_io_thread
> monitor: delay monitor iothread creation
Hi, Wolfgang,
Do you have plan to repost this series?
Regards,
--
Peter Xu
next parent reply other threads:[~2018-10-11 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180928075832.18586-1-w.bumiller@proxmox.com>
2018-10-11 0:09 ` Peter Xu [this message]
[not found] ` <20180928075832.18586-3-w.bumiller@proxmox.com>
[not found] ` <CAJ+F1CL4S8aLm6ayu7GfKMfySTBTuUS3j2cuni-+ErEp5Y8VLQ@mail.gmail.com>
[not found] ` <20180928095543.GN9560@xz-x1>
2018-10-11 6:30 ` [Qemu-devel] [PATCH v2 2/2] monitor: delay monitor iothread creation Markus Armbruster
2018-10-11 8:23 ` Wolfgang Bumiller
2018-10-11 9:49 ` Markus Armbruster
2018-10-30 18:44 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011000933.GB5014@xz-x1 \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).