qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on image locking
Date: Thu, 11 Oct 2018 15:21:32 +0800	[thread overview]
Message-ID: <20181011072135.588-1-famz@redhat.com> (raw)

v5: Address Max's comments (Thanks for reviewing):
    - Clean up after test done.
    - Add rev-by to patch 1 and 2.

v4: Fix test on systems without OFD. [Patchew]

The first patch reduces chances of QEMU crash in unusual (but not unlikely)
cases especially when used by Libvirt (see commit message).

The second patch halves fd for images.

The third adds some more test for patch one (would have caught the regression
caused by v2).

Fam Zheng (3):
  file-posix: Skip effectiveless OFD lock operations
  file-posix: Drop s->lock_fd
  tests: Add unit tests for image locking

 block/file-posix.c         |  83 +++++++++++++-------
 tests/Makefile.include     |   2 +
 tests/test-image-locking.c | 157 +++++++++++++++++++++++++++++++++++++
 3 files changed, 212 insertions(+), 30 deletions(-)
 create mode 100644 tests/test-image-locking.c

-- 
2.17.1

             reply	other threads:[~2018-10-11  7:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  7:21 Fam Zheng [this message]
2018-10-11  7:21 ` [Qemu-devel] [PATCH v5 1/3] file-posix: Skip effectiveless OFD lock operations Fam Zheng
2018-10-11  7:21 ` [Qemu-devel] [PATCH v5 2/3] file-posix: Drop s->lock_fd Fam Zheng
2018-11-14 13:54   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-11-16 13:34     ` Max Reitz
2018-11-16 13:58       ` Alberto Garcia
2018-11-16 14:02         ` Max Reitz
2018-11-16 14:16           ` Max Reitz
2018-10-11  7:21 ` [Qemu-devel] [PATCH v5 3/3] tests: Add unit tests for image locking Fam Zheng
2018-11-08  3:16 ` [Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on " Fam Zheng
2018-11-08  9:26 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011072135.588-1-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).