From: Peter Krempa <pkrempa@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] block: Add auto-read-only option
Date: Thu, 11 Oct 2018 10:29:17 +0200 [thread overview]
Message-ID: <20181011082917.GI2052@andariel.pipo.sk> (raw)
In-Reply-To: <20181009193524.19052-1-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Tue, Oct 09, 2018 at 21:35:20 +0200, Kevin Wolf wrote:
> Peter, would this provide what libvirt urgently needs for backing files
> vs. the commit block job?
This looks fine for us with one exception. I'd prefer if the curl driver
implemented this too so that we don't have to hardcode the readonly flag
for that as well.
With CURL based backend backing an image I get:
-blockdev {"driver":"http","url":"example.com","node-name":"libvirt-2-storage","discard":"unmap","auto-read-only":true}: curl block device does not support writes
I've tested it with libvirt's usage of -blockdev together with
block-commit and also with read-only-NBD backed images and everything
seems to work well for me. I'll report back once I give it more testing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-10-11 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 19:35 [Qemu-devel] [PATCH 0/4] block: Add auto-read-only option Kevin Wolf
2018-10-09 19:35 ` [Qemu-devel] [PATCH 1/4] block: Update flags in bdrv_set_read_only() Kevin Wolf
2018-10-09 19:35 ` [Qemu-devel] [PATCH 2/4] block: Add auto-read-only option Kevin Wolf
2018-10-09 19:35 ` [Qemu-devel] [PATCH 3/4] nbd: Support " Kevin Wolf
2018-10-09 19:35 ` [Qemu-devel] [PATCH 4/4] file-posix: " Kevin Wolf
2018-10-11 8:29 ` Peter Krempa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011082917.GI2052@andariel.pipo.sk \
--to=pkrempa@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).