* [Qemu-devel] [PATCH] piix_pci: change the i440fx data sheet link
@ 2018-10-11 14:44 Li Qiang
2018-10-11 15:01 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Li Qiang @ 2018-10-11 14:44 UTC (permalink / raw)
To: mst, marcel.apfelbaum; +Cc: qemu-devel, Li Qiang
Seems the intel link is unavailable, change it to qemu site.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
hw/pci-host/piix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0e608347c1..e709abeb08 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -40,7 +40,7 @@
/*
* I440FX chipset data sheet.
- * http://download.intel.com/design/chipsets/datashts/29054901.pdf
+ * https://wiki.qemu.org/images/b/bb/29054901.pdf
*/
#define I440FX_PCI_HOST_BRIDGE(obj) \
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] piix_pci: change the i440fx data sheet link
2018-10-11 14:44 [Qemu-devel] [PATCH] piix_pci: change the i440fx data sheet link Li Qiang
@ 2018-10-11 15:01 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-11 15:01 UTC (permalink / raw)
To: Li Qiang, mst, marcel.apfelbaum; +Cc: qemu-devel
Hi Li,
On 11/10/2018 16:44, Li Qiang wrote:
> Seems the intel link is unavailable, change it to qemu site.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> hw/pci-host/piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..e709abeb08 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -40,7 +40,7 @@
>
> /*
> * I440FX chipset data sheet.
> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> + * https://wiki.qemu.org/images/b/bb/29054901.pdf
Good idea, but please use: https://wiki.qemu.org/File:29054901.pdf
With this change:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> */
>
> #define I440FX_PCI_HOST_BRIDGE(obj) \
>
Thanks,
Phil.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 14:44 [Qemu-devel] [PATCH] piix_pci: change the i440fx data sheet link Li Qiang
2018-10-11 15:01 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).