From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAx8a-0000j0-W7 for qemu-devel@nongnu.org; Fri, 12 Oct 2018 09:05:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAx8W-000162-JA for qemu-devel@nongnu.org; Fri, 12 Oct 2018 09:05:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59702) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gAx8S-0000zA-SG for qemu-devel@nongnu.org; Fri, 12 Oct 2018 09:05:46 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E81D012F918 for ; Fri, 12 Oct 2018 13:05:41 +0000 (UTC) Date: Fri, 12 Oct 2018 07:05:38 -0600 From: Alex Williamson Message-ID: <20181012070538.121f85a1@t450s.home> In-Reply-To: <20181012084302.so3aptiavcgvbbyh@sirius.home.kraxel.org> References: <20180917061729.22407-1-kraxel@redhat.com> <20180917061729.22407-3-kraxel@redhat.com> <20181011151941.77cd8516@w520.home> <20181012084302.so3aptiavcgvbbyh@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/2] hw/vfio/display: add ramfb support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Paolo Bonzini On Fri, 12 Oct 2018 10:43:02 +0200 Gerd Hoffmann wrote: > Hi, > > > > OnOffAuto display; > > > + bool enable_ramfb; > > > int32_t bootindex; > > > uint32_t igd_gms; > > > OffAutoPCIBAR msix_relo; > > > > Hi Gerd, > > > > One tiny nit here, we can move this new bool down in the struct with > > the rest of the bools for better alignment. I can change that on > > commit. > > I've grouped it with the display option because it is display related > too, but if you prefer to group the bools instead this is fine with me. Not so much grouping the bools as simply making the struct a bit more space efficient by not adding obvious alignment holes. > > However, I'm not having luck getting ramfb to work; the > > display is only getting initialized once the guest driver loads. This > > is a 440FX/SeaBIOS VM, it looks like you've already updated bios.bin in > > qemu.git with ramfb support, > > Yes, seabios (and vgabios) bundled with 3.0 (and master branch) should work fine. > > There is a standalone device you can use for testing (-vga none -device > ramfb), to see whenever the firmware side of things works correctly. > > OVMF has ramfb support too btw (merged a few months back). Yes, I'm also trying with an OVMF build from your firmware repo. > > -device vfio-pci-nohotplug,id=hostdev0,sysfsdev=...,display=on,bus=pci.0,addr=0x9 \ > > > > > > >
> > > >
> > > > Hmm, that actually uses vfio-pci-nohotplug? > But when ramfb=on doesn't throw an error, then yes, appearently. That's where my wrapper script was replacing s/vfio-pci/vfio-pci-nohotplug/, I didn't know about the driver override you list below, that's much cleaner. > > > > > > > > > > > > > > I have this (additionally): > > > > > > This is a Windows 10 VM, but as I understand this ramfb support, I > > think I'm still supposed to see SeaBIOS boot messages and perhaps even > > the Windows boot animation before the guest driver takes over, is that > > correct? > > Yes, you should see both. Ok, I'll update my xml and also try the raw ramfb device and see if I can make it work. Thanks, Alex