From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 4/7] qxl: check qxl_phys2virt return value
Date: Mon, 15 Oct 2018 11:05:14 +0200 [thread overview]
Message-ID: <20181015090517.26884-5-kraxel@redhat.com> (raw)
In-Reply-To: <20181015090517.26884-1-kraxel@redhat.com>
Fixes: CID 1395986
Fixes: 979f7ef8966bc4495a710ed9e4af42098f92ee79
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20181005134608.1251-1-kraxel@redhat.com
---
hw/display/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index e628cf1286..f608abc769 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -290,7 +290,7 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)
}
cfg = qxl_phys2virt(qxl, qxl->guest_monitors_config, MEMSLOT_GROUP_GUEST);
- if (cfg->count == 1) {
+ if (cfg != NULL && cfg->count == 1) {
qxl->guest_primary.resized = 1;
qxl->guest_head0_width = cfg->heads[0].width;
qxl->guest_head0_height = cfg->heads[0].height;
--
2.9.3
next prev parent reply other threads:[~2018-10-15 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 9:05 [Qemu-devel] [PULL 0/7] Vga 20181015 patches Gerd Hoffmann
2018-10-15 9:05 ` [Qemu-devel] [PULL 1/7] edid: fix alignment issues Gerd Hoffmann
2018-10-15 9:05 ` [Qemu-devel] [PULL 2/7] display: add separate config option for bochs-display Gerd Hoffmann
2018-10-15 9:05 ` [Qemu-devel] [PULL 3/7] bochs-display: wire up edid support Gerd Hoffmann
2018-10-15 9:05 ` Gerd Hoffmann [this message]
2018-10-15 9:05 ` [Qemu-devel] [PULL 5/7] i2c: switch ddc to use the new edid generator Gerd Hoffmann
2018-10-15 9:05 ` [Qemu-devel] [PULL 6/7] hw/display/cirrus_vga: Move "isa-cirrus-vga" device into a separate file Gerd Hoffmann
2018-10-15 9:05 ` [Qemu-devel] [PULL 7/7] Makefile: Install new vgabios binaries Gerd Hoffmann
2018-10-15 16:01 ` [Qemu-devel] [PULL 0/7] Vga 20181015 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015090517.26884-5-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).