From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 00/35] Replace some unwise uses of error_report() & friends
Date: Mon, 15 Oct 2018 13:52:34 +0200 [thread overview]
Message-ID: <20181015115309.17089-1-armbru@redhat.com> (raw)
Calling error_report() or similar in a function that takes an Error **
argument is suspicious. Fix a number of instances that are actually
wrong. Clean up a few more that are merely fragile / bad examples.
v2:
* PATCH 01: New
* PATCH 02: Commit hash corrected in commit message [Eric]
* PATCH 13: Error messages tidied up [Marc-André]
* PATCH 15: Commit message tidied up [Eduardo H.]
* PATCH 16: Unwanted string split fixed [Marc-André, Eduardo O.]
* PATCH 20: Commit message corrected [Marc-André]
* PATCH 25-26: New
* PATCH 27: Rebased, commit message corrected
* PATCH 30: Commit message tidied up [Eric]
* PATCH 32: Less confusing commit message, help fixed [Max]
* PATCH 33: New
Fei Li (1):
ui: Convert vnc_display_init(), init_keyboard_layout() to Error
Markus Armbruster (34):
error: Fix use of error_prepend() with &error_fatal, &error_abort
Use error_fatal to simplify obvious fatal errors (again)
block: Use warn_report() & friends to report warnings
cpus hw target: Use warn_report() & friends to report warnings
vfio: Use warn_report() & friends to report warnings
vfio: Clean up error reporting after previous commit
char: Use error_printf() to print help and such
9pfs: Fix CLI parsing crash on error
pc: Fix machine property nvdimm-persistence error handling
ioapic: Fix error handling in realize()
smbios: Clean up error handling in smbios_add()
migration: Fix !replay_can_snapshot() error handling
l2tpv3: Improve -netdev/netdev_add/-net/... error reporting
net/socket: Fix invalid socket type error handling
numa: Fix QMP command set-numa-node error handling
xen/pt: Fix incomplete conversion to realize()
seccomp: Clean up error reporting in parse_sandbox()
vl: Clean up error reporting in parse_add_fd()
qom: Clean up error reporting in user_creatable_add_opts_foreach()
vl: Clean up error reporting in chardev_init_func()
vl: Clean up error reporting in machine_set_property()
vl: Clean up error reporting in mon_init_func()
vl: Clean up error reporting in parse_fw_cfg()
vl: Clean up error reporting in device_init_func()
ui/keymaps: Fix handling of erroneous include files
vnc: Clean up error reporting in vnc_init_func()
numa: Clean up error reporting in parse_numa()
tpm: Clean up error reporting in tpm_init_tpmdev()
spice: Clean up error reporting in add_channel()
fsdev: Clean up error reporting in qemu_fsdev_add()
vl: Assert drive_new() does not fail in default_drive()
blockdev: Convert drive_new() to Error
vl: Fix exit status for -drive format=help
vl: Simplify call of parse_name()
Fei Li (1):
ui: Convert vnc_display_init(), init_keyboard_layout() to Error
Markus Armbruster (34):
error: Fix use of error_prepend() with &error_fatal, &error_abort
Use error_fatal to simplify obvious fatal errors (again)
block: Use warn_report() & friends to report warnings
cpus hw target: Use warn_report() & friends to report warnings
vfio: Use warn_report() & friends to report warnings
vfio: Clean up error reporting after previous commit
char: Use error_printf() to print help and such
9pfs: Fix CLI parsing crash on error
pc: Fix machine property nvdimm-persistence error handling
ioapic: Fix error handling in realize()
smbios: Clean up error handling in smbios_add()
migration: Fix !replay_can_snapshot() error handling
l2tpv3: Improve -netdev/netdev_add/-net/... error reporting
net/socket: Fix invalid socket type error handling
numa: Fix QMP command set-numa-node error handling
xen/pt: Fix incomplete conversion to realize()
seccomp: Clean up error reporting in parse_sandbox()
vl: Clean up error reporting in parse_add_fd()
qom: Clean up error reporting in user_creatable_add_opts_foreach()
vl: Clean up error reporting in chardev_init_func()
vl: Clean up error reporting in machine_set_property()
vl: Clean up error reporting in mon_init_func()
vl: Clean up error reporting in parse_fw_cfg()
vl: Clean up error reporting in device_init_func()
ui/keymaps: Fix handling of erroneous include files
vnc: Clean up error reporting in vnc_init_func()
numa: Clean up error reporting in parse_numa()
tpm: Clean up error reporting in tpm_init_tpmdev()
spice: Clean up error reporting in add_channel()
fsdev: Clean up error reporting in qemu_fsdev_add()
vl: Assert drive_new() does not fail in default_drive()
blockdev: Convert drive_new() to Error
vl: Fix exit status for -drive format=help
vl: Simplify call of parse_name()
block.c | 6 +-
block/bochs.c | 8 +-
block/cloop.c | 8 +-
block/dmg.c | 8 +-
block/iscsi.c | 2 +-
block/qcow2.c | 4 +-
block/qed.c | 4 +-
block/rbd.c | 12 +-
block/sheepdog.c | 2 +-
block/vvfat.c | 8 +-
blockdev.c | 27 ++---
chardev/char-pty.c | 2 +-
chardev/char.c | 2 +-
cpus.c | 8 +-
device-hotplug.c | 5 +-
fsdev/qemu-fsdev-dummy.c | 2 +-
fsdev/qemu-fsdev.c | 12 +-
fsdev/qemu-fsdev.h | 2 +-
hw/9pfs/9p-handle.c | 6 +-
hw/9pfs/9p-local.c | 4 +-
hw/9pfs/xen-9p-backend.c | 7 +-
hw/display/cg3.c | 2 +-
hw/display/tcx.c | 2 +-
hw/i386/pc.c | 5 +-
hw/intc/ioapic.c | 8 +-
hw/intc/xics.c | 15 ++-
hw/intc/xics_kvm.c | 7 +-
hw/misc/ivshmem.c | 4 +-
hw/net/virtio-net.c | 8 +-
hw/ppc/pnv_core.c | 4 +-
hw/ppc/spapr_pci.c | 7 +-
hw/smbios/smbios.c | 90 ++++++++++-----
hw/timer/aspeed_timer.c | 3 +-
hw/usb/bus.c | 5 +-
hw/vfio/pci-quirks.c | 4 +-
hw/vfio/pci.c | 25 ++--
hw/vfio/platform.c | 6 +-
hw/virtio/virtio-pci.c | 4 +-
hw/xen/xen_pt.c | 2 +-
include/hw/vfio/vfio-common.h | 3 +-
include/qapi/error.h | 14 +++
include/sysemu/blockdev.h | 3 +-
include/sysemu/numa.h | 1 -
include/sysemu/tpm.h | 2 +-
include/ui/console.h | 2 +-
migration/migration.c | 12 +-
migration/savevm.c | 8 +-
net/l2tpv3.c | 25 ++--
net/socket.c | 4 +-
numa.c | 21 ++--
qemu-io.c | 8 +-
qemu-nbd.c | 14 +--
qemu-seccomp.c | 18 +--
qom/object_interfaces.c | 4 +-
scripts/coccinelle/use-error_fatal.cocci | 20 ++++
stubs/tpm.c | 3 +-
target/i386/cpu.c | 17 +--
target/ppc/translate_init.inc.c | 4 +-
tpm.c | 22 ++--
ui/curses.c | 6 +-
ui/keymaps.c | 40 ++++---
ui/keymaps.h | 2 +-
ui/sdl.c | 6 +-
ui/spice-core.c | 13 ++-
ui/vnc.c | 20 ++--
util/error.c | 13 +++
vl.c | 139 +++++++++--------------
67 files changed, 422 insertions(+), 362 deletions(-)
create mode 100644 scripts/coccinelle/use-error_fatal.cocci
--
2.17.1
next reply other threads:[~2018-10-15 11:53 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 11:52 Markus Armbruster [this message]
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 01/35] error: Fix use of error_prepend() with &error_fatal, &error_abort Markus Armbruster
2018-10-15 18:49 ` Eric Blake
2018-10-15 22:52 ` Philippe Mathieu-Daudé
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 02/35] Use error_fatal to simplify obvious fatal errors (again) Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 03/35] block: Use warn_report() & friends to report warnings Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 04/35] cpus hw target: " Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 05/35] vfio: " Markus Armbruster
2018-10-15 18:53 ` Eric Blake
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 06/35] vfio: Clean up error reporting after previous commit Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 07/35] char: Use error_printf() to print help and such Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 08/35] 9pfs: Fix CLI parsing crash on error Markus Armbruster
2018-10-15 19:00 ` Eric Blake
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 09/35] pc: Fix machine property nvdimm-persistence error handling Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 10/35] ioapic: Fix error handling in realize() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 11/35] smbios: Clean up error handling in smbios_add() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 12/35] migration: Fix !replay_can_snapshot() error handling Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 13/35] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 14/35] net/socket: Fix invalid socket type error handling Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 15/35] numa: Fix QMP command set-numa-node " Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 16/35] xen/pt: Fix incomplete conversion to realize() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 17/35] seccomp: Clean up error reporting in parse_sandbox() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 18/35] vl: Clean up error reporting in parse_add_fd() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 19/35] qom: Clean up error reporting in user_creatable_add_opts_foreach() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 20/35] vl: Clean up error reporting in chardev_init_func() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 21/35] vl: Clean up error reporting in machine_set_property() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 22/35] vl: Clean up error reporting in mon_init_func() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 23/35] vl: Clean up error reporting in parse_fw_cfg() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 24/35] vl: Clean up error reporting in device_init_func() Markus Armbruster
2018-10-15 11:52 ` [Qemu-devel] [PATCH v2 25/35] ui/keymaps: Fix handling of erroneous include files Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 26/35] ui: Convert vnc_display_init(), init_keyboard_layout() to Error Markus Armbruster
2018-10-15 22:42 ` Philippe Mathieu-Daudé
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 27/35] vnc: Clean up error reporting in vnc_init_func() Markus Armbruster
2018-10-15 12:51 ` Fei Li
2018-10-16 4:08 ` Markus Armbruster
2018-10-16 6:52 ` Gerd Hoffmann
2018-10-16 11:21 ` Markus Armbruster
2018-10-15 22:41 ` Philippe Mathieu-Daudé
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 28/35] numa: Clean up error reporting in parse_numa() Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 29/35] tpm: Clean up error reporting in tpm_init_tpmdev() Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 30/35] spice: Clean up error reporting in add_channel() Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 31/35] fsdev: Clean up error reporting in qemu_fsdev_add() Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 32/35] vl: Assert drive_new() does not fail in default_drive() Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 33/35] blockdev: Convert drive_new() to Error Markus Armbruster
2018-10-15 14:48 ` Max Reitz
2018-10-15 18:54 ` Eric Blake
2018-10-15 22:38 ` Philippe Mathieu-Daudé
2018-10-16 4:09 ` Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 34/35] vl: Fix exit status for -drive format=help Markus Armbruster
2018-10-15 11:53 ` [Qemu-devel] [PATCH v2 35/35] vl: Simplify call of parse_name() Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015115309.17089-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).