qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Emilio G. Cota" <cota@braap.org>
Subject: [Qemu-devel] [PULL 06/21] target/alpha: remove tlb_flush from alpha_cpu_initfn
Date: Tue, 16 Oct 2018 10:48:56 -0700	[thread overview]
Message-ID: <20181016174911.9052-7-richard.henderson@linaro.org> (raw)
In-Reply-To: <20181016174911.9052-1-richard.henderson@linaro.org>

From: "Emilio G. Cota" <cota@braap.org>

As far as I can tell tlb_flush does not need to be called
this early. tlb_flush is eventually called after the CPU
has been realized.

This change paves the way to the introduction of tlb_init,
which will be called from cpu_exec_realizefn.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Message-Id: <20181009174557.16125-2-cota@braap.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/alpha/cpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c
index b08078e7fc..a953897fcc 100644
--- a/target/alpha/cpu.c
+++ b/target/alpha/cpu.c
@@ -201,7 +201,6 @@ static void alpha_cpu_initfn(Object *obj)
     CPUAlphaState *env = &cpu->env;
 
     cs->env_ptr = env;
-    tlb_flush(cs);
 
     env->lock_addr = -1;
 #if defined(CONFIG_USER_ONLY)
-- 
2.17.2

  parent reply	other threads:[~2018-10-16 17:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 17:48 [Qemu-devel] [PULL 00/21] tcg patch queue Richard Henderson
2018-10-16 17:48 ` [Qemu-devel] [PULL 01/21] tcg: Implement CPU_LOG_TB_NOCHAIN during expansion Richard Henderson
2018-10-16 17:48 ` [Qemu-devel] [PULL 02/21] tcg: access cpu->icount_decr.u16.high with atomics Richard Henderson
2018-10-16 17:48 ` [Qemu-devel] [PULL 03/21] tcg: fix use of uninitialized variable under CONFIG_PROFILER Richard Henderson
2018-10-16 17:48 ` [Qemu-devel] [PULL 04/21] tcg: plug holes in struct TCGProfile Richard Henderson
2018-10-16 17:48 ` [Qemu-devel] [PULL 05/21] tcg: distribute tcg_time into TCG contexts Richard Henderson
2018-10-16 17:48 ` Richard Henderson [this message]
2018-10-16 17:48 ` [Qemu-devel] [PULL 07/21] target/unicore32: remove tlb_flush from uc32_init_fn Richard Henderson
2018-10-16 17:48 ` [Qemu-devel] [PULL 08/21] exec: introduce tlb_init Richard Henderson
2018-10-16 17:48 ` [Qemu-devel] [PULL 09/21] cputlb: fix assert_cpu_is_self macro Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 10/21] cputlb: serialize tlb updates with env->tlb_lock Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 11/21] tcg: Add tlb_index and tlb_entry helpers Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 12/21] tcg: Split CONFIG_ATOMIC128 Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 13/21] target/i386: Convert to HAVE_CMPXCHG128 Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 14/21] target/arm: " Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 15/21] target/arm: Check HAVE_CMPXCHG128 at translate time Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 16/21] target/ppc: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128 Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 17/21] target/s390x: " Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 18/21] target/s390x: Split do_cdsg, do_lpq, do_stpq Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 19/21] target/s390x: Skip wout, cout helpers if op helper does not return Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 20/21] target/s390x: Check HAVE_ATOMIC128 and HAVE_CMPXCHG128 at translate Richard Henderson
2018-10-16 17:49 ` [Qemu-devel] [PULL 21/21] cputlb: read CPUTLBEntry.addr_write atomically Richard Henderson
2018-10-18 10:34 ` [Qemu-devel] [PULL 00/21] tcg patch queue Peter Maydell
2018-10-19  6:10   ` Richard Henderson
2018-10-21 15:01     ` Peter Maydell
2018-10-21 15:21       ` Peter Maydell
2018-10-22 17:47         ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016174911.9052-7-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=cota@braap.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).