[Qemu-devel] [PULL 0/1] target/hppa patch queue

[Qemu-devel] [PULL 0/1] target/hppa patch queue

[Richard Henderson]

The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into staging (2018-10-16 17:42:56 +0100)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-hppa-20181016

for you to fetch changes up to 5f538f75324ef69d624b5f71ab2c7f4e72a7d744:

  target/hppa: Raise exception 26 on emulated hardware (2018-10-16 15:32:22 -0700)

----------------------------------------------------------------
Queued hppa patch

----------------------------------------------------------------
Helge Deller (1):
      target/hppa: Raise exception 26 on emulated hardware

 target/hppa/mem_helper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 1/1] target/hppa: Raise exception 26 on emulated hardware

[Richard Henderson]

From: Helge Deller <deller@gmx.de>

On PCXS chips (PA7000, pa 1.1a), trap #18 is raised on memory faults,
while all later chips (>= PA7100) generate either trap #26, #27 or #28
(depending on the fault type).

Since the current qemu emulation emulates a B160L machine (with a
PA7300LC PCX-L2 chip, we should raise trap #26 (EXCP_DMAR) instead
of #18 (EXCP_DMP) on access faults by the Linux kernel to page zero.

With the patch we now get the correct output (I tested against real
hardware):
 Kernel Fault: Code=26 (Data memory access rights trap)
instead of:
 Kernel Fault: Code=18 (Data memory protection/unaligned access trap)

Signed-off-by: Helge Deller <deller@gmx.de>
Message-Id: <20181007205153.GA30270@ls3530.fritz.box>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/hppa/mem_helper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index ab160c2a74..aecf3075f6 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -137,7 +137,8 @@ int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx,
 
     if (unlikely(!(prot & type))) {
         /* The access isn't allowed -- Inst/Data Memory Protection Fault.  */
-        ret = (type & PAGE_EXEC ? EXCP_IMP : EXCP_DMP);
+        ret = (type & PAGE_EXEC ? EXCP_IMP :
+               prot & PAGE_READ ? EXCP_DMP : EXCP_DMAR);
         goto egress;
     }
 
-- 
2.17.2

Re: [Qemu-devel] [PULL 0/1] target/hppa patch queue

[Peter Maydell]

On 16 October 2018 at 23:47, Richard Henderson
<richard.henderson@linaro.org> wrote:
> The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into staging (2018-10-16 17:42:56 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-hppa-20181016
>
> for you to fetch changes up to 5f538f75324ef69d624b5f71ab2c7f4e72a7d744:
>
>   target/hppa: Raise exception 26 on emulated hardware (2018-10-16 15:32:22 -0700)
>
> ----------------------------------------------------------------
> Queued hppa patch
>
> ----------------------------------------------------------------
> Helge Deller (1):
>       target/hppa: Raise exception 26 on emulated hardware
>
>  target/hppa/mem_helper.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)


Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/1] target/hppa patch queue

[Richard Henderson]

The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:

  Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-hppa-20190221

for you to fetch changes up to 368bec88d1916f65050be305f88c10a46075a51c:

  hw/hppa/dino: mask out lower 2 bits of PCI config addr (2019-02-21 10:16:19 -0800)

----------------------------------------------------------------
Fix dino pci config access.

----------------------------------------------------------------
Sven Schnelle (1):
      hw/hppa/dino: mask out lower 2 bits of PCI config addr

 hw/hppa/dino.c            |  27 ++++++++++++++++++++++++---
 pc-bios/hppa-firmware.img | Bin 215936 -> 760040 bytes
 2 files changed, 24 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PULL 0/1] target/hppa patch queue

[Peter Maydell]

On Thu, 21 Feb 2019 at 19:04, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
>
>   Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-hppa-20190221
>
> for you to fetch changes up to 368bec88d1916f65050be305f88c10a46075a51c:
>
>   hw/hppa/dino: mask out lower 2 bits of PCI config addr (2019-02-21 10:16:19 -0800)
>
> ----------------------------------------------------------------
> Fix dino pci config access.
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

Re: [Qemu-devel] [PULL 0/1] target/hppa patch queue

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190221190426.22810-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190221190426.22810-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PULL 0/1] target/hppa patch queue
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1550847320-25110-1-git-send-email-jasowang@redhat.com -> patchew/1550847320-25110-1-git-send-email-jasowang@redhat.com
 * [new tag]               patchew/20190221190426.22810-1-richard.henderson@linaro.org -> patchew/20190221190426.22810-1-richard.henderson@linaro.org
 t [tag update]            patchew/20190225152015.26089-1-eblake@redhat.com -> patchew/20190225152015.26089-1-eblake@redhat.com
 t [tag update]            patchew/20190225200318.16102-1-david@redhat.com -> patchew/20190225200318.16102-1-david@redhat.com
 * [new tag]               patchew/20190226193408.23862-1-armbru@redhat.com -> patchew/20190226193408.23862-1-armbru@redhat.com
Switched to a new branch 'test'

=== OUTPUT BEGIN ===
checkpatch.pl: no revisions returned for revlist '1'
=== OUTPUT END ===

Test command exited with code: 255


The full log is available at
http://patchew.org/logs/20190221190426.22810-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com