From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>,
Artem Pisarenko <artem.k.pisarenko@gmail.com>
Subject: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call"
Date: Wed, 17 Oct 2018 11:07:50 +0200 [thread overview]
Message-ID: <20181017090750.4378-1-pbonzini@redhat.com> (raw)
QEMU running with options "-icount,sleep=off -rtc clock=vm" doesn't
execute emulation at maximum possible speed.
Target virtual clock may run faster or slower than realtime clock by N
times, where N value depends on various unrelated conditions (i.e. random
from the user point of view), or possibly the target hangs completely.
Bisection shows commit 281b2201e4 ("icount: remove obsolete warp call",
2016-03-15) to be the culprit, revert it.
Suggested-by: Artem Pisarenko <artem.k.pisarenko@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
cpus.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/cpus.c b/cpus.c
index 361678e459..2872e7e37c 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1224,6 +1224,10 @@ static void qemu_tcg_rr_wait_io_event(CPUState *cpu)
{
while (all_cpu_threads_idle()) {
stop_tcg_kick_timer();
+
+ /* Start accounting real time to the virtual clock if the CPUs
+ are idle. */
+ qemu_clock_warp(QEMU_CLOCK_VIRTUAL);
qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
}
--
2.17.1
next reply other threads:[~2018-10-17 9:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:07 Paolo Bonzini [this message]
2018-10-17 9:37 ` [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call" Pavel Dovgalyuk
2018-10-17 9:53 ` Artem Pisarenko
2018-10-17 10:17 ` Paolo Bonzini
2018-10-17 11:38 ` Pavel Dovgalyuk
2018-10-17 11:42 ` Paolo Bonzini
2018-10-17 11:43 ` Pavel Dovgalyuk
2018-10-17 12:30 ` Alex Bennée
2018-10-17 12:11 ` Pavel Dovgalyuk
2018-10-17 13:20 ` Pavel Dovgalyuk
2018-10-17 13:32 ` Artem Pisarenko
2018-10-18 5:49 ` Pavel Dovgalyuk
2018-10-17 14:43 ` Paolo Bonzini
2018-10-18 2:22 ` Clement Deschamps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017090750.4378-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=artem.k.pisarenko@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).