qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] vpc: Don't leak opts in vpc_open()
@ 2018-10-17 13:33 Kevin Wolf
  2018-10-17 15:29 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2018-10-17 13:33 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, qemu-devel

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/vpc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/vpc.c b/block/vpc.c
index bf294abfa7..eace2ba484 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -454,10 +454,12 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
     }
 
     qemu_co_mutex_init(&s->lock);
+    qemu_opts_del(opts);
 
     return 0;
 
 fail:
+    qemu_opts_del(opts);
     qemu_vfree(s->pagetable);
 #ifdef CACHE
     g_free(s->pageentry_u8);
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [Qemu-block] [PATCH] vpc: Don't leak opts in vpc_open()
  2018-10-17 13:33 [Qemu-devel] [PATCH] vpc: Don't leak opts in vpc_open() Kevin Wolf
@ 2018-10-17 15:29 ` Alberto Garcia
  0 siblings, 0 replies; 2+ messages in thread
From: Alberto Garcia @ 2018-10-17 15:29 UTC (permalink / raw)
  To: Kevin Wolf, qemu-block; +Cc: qemu-devel

On Wed 17 Oct 2018 03:33:50 PM CEST, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-17 15:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-17 13:33 [Qemu-devel] [PATCH] vpc: Don't leak opts in vpc_open() Kevin Wolf
2018-10-17 15:29 ` [Qemu-devel] [Qemu-block] " Alberto Garcia

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).