* Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd) [not found] ` <20180928145411.GN5738@habkost.net> @ 2018-10-17 18:12 ` Sebastian Andrzej Siewior 2018-10-17 18:40 ` Paolo Bonzini 0 siblings, 1 reply; 3+ messages in thread From: Sebastian Andrzej Siewior @ 2018-10-17 18:12 UTC (permalink / raw) To: Eduardo Habkost; +Cc: qemu-devel, tglx, Paolo Bonzini, Richard Henderson On 2018-09-28 11:54:11 [-0300], Eduardo Habkost wrote: > On Fri, Sep 28, 2018 at 12:43:19PM +0200, Sebastian Andrzej Siewior wrote: > > Intel SDM says for CPUID function 0DH, sub-function 0: > > > > | • ECX enumerates the size (in bytes) required by the XSAVE instruction for an > > | XSAVE area containing all the user state components supported by this > > | processor. > > | • EBX enumerates the size (in bytes) required by the XSAVE instruction for an > > | XSAVE area containing all the user state components corresponding to bits > > | currently set in XCR0. > > > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > --- > > target/i386/cpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index f24295e6e4bb7..00c18444c0bac 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -4178,7 +4178,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, > > *ecx = xsave_area_size(x86_cpu_xsave_components(cpu)); > > *eax = env->features[FEAT_XSAVE_COMP_LO]; > > *edx = env->features[FEAT_XSAVE_COMP_HI]; > > - *ebx = *ecx; > > + *ebx = xsave_area_size(env->xcr0); > > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> ping Sebastian ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd) 2018-10-17 18:12 ` [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd) Sebastian Andrzej Siewior @ 2018-10-17 18:40 ` Paolo Bonzini 2018-10-17 18:42 ` Sebastian Andrzej Siewior 0 siblings, 1 reply; 3+ messages in thread From: Paolo Bonzini @ 2018-10-17 18:40 UTC (permalink / raw) To: Sebastian Andrzej Siewior, Eduardo Habkost Cc: qemu-devel, tglx, Richard Henderson On 17/10/2018 20:12, Sebastian Andrzej Siewior wrote: > On 2018-09-28 11:54:11 [-0300], Eduardo Habkost wrote: >> On Fri, Sep 28, 2018 at 12:43:19PM +0200, Sebastian Andrzej Siewior wrote: >>> Intel SDM says for CPUID function 0DH, sub-function 0: >>> >>> | • ECX enumerates the size (in bytes) required by the XSAVE instruction for an >>> | XSAVE area containing all the user state components supported by this >>> | processor. >>> | • EBX enumerates the size (in bytes) required by the XSAVE instruction for an >>> | XSAVE area containing all the user state components corresponding to bits >>> | currently set in XCR0. >>> >>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >>> --- >>> target/i386/cpu.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c >>> index f24295e6e4bb7..00c18444c0bac 100644 >>> --- a/target/i386/cpu.c >>> +++ b/target/i386/cpu.c >>> @@ -4178,7 +4178,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, >>> *ecx = xsave_area_size(x86_cpu_xsave_components(cpu)); >>> *eax = env->features[FEAT_XSAVE_COMP_LO]; >>> *edx = env->features[FEAT_XSAVE_COMP_HI]; >>> - *ebx = *ecx; >>> + *ebx = xsave_area_size(env->xcr0); >> >> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > > ping It's queued for my next pull request. Paolo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd) 2018-10-17 18:40 ` Paolo Bonzini @ 2018-10-17 18:42 ` Sebastian Andrzej Siewior 0 siblings, 0 replies; 3+ messages in thread From: Sebastian Andrzej Siewior @ 2018-10-17 18:42 UTC (permalink / raw) To: Paolo Bonzini; +Cc: Eduardo Habkost, qemu-devel, tglx, Richard Henderson On 2018-10-17 20:40:17 [+0200], Paolo Bonzini wrote: > It's queued for my next pull request. thanks. > Paolo Sebastian ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-17 18:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180928104319.3296-1-bigeasy@linutronix.de>
[not found] ` <20180928145411.GN5738@habkost.net>
2018-10-17 18:12 ` [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd) Sebastian Andrzej Siewior
2018-10-17 18:40 ` Paolo Bonzini
2018-10-17 18:42 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).