From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com,
kwangwoo.lee@sk.com, imammedo@redhat.com, david@redhat.com
Cc: drjones@redhat.com, dgilbert@redhat.com, Suzuki.Poulose@arm.com
Subject: [Qemu-devel] [RFC v4 11/16] acpi: move build_srat_hotpluggable_memory to generic ACPI source
Date: Thu, 18 Oct 2018 16:30:37 +0200 [thread overview]
Message-ID: <20181018143042.29588-12-eric.auger@redhat.com> (raw)
In-Reply-To: <20181018143042.29588-1-eric.auger@redhat.com>
We plan to reuse build_srat_hotpluggable_memory() for ARM so
let's move the function to aml-build.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
hw/acpi/aml-build.c | 51 +++++++++++++++++++++++++++++++++++++
include/hw/acpi/aml-build.h | 3 +++
2 files changed, 54 insertions(+)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 1e43cd736d..167fb6bf3e 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -22,6 +22,7 @@
#include "qemu/osdep.h"
#include <glib/gprintf.h>
#include "hw/acpi/aml-build.h"
+#include "hw/mem/memory-device.h"
#include "qemu/bswap.h"
#include "qemu/bitops.h"
#include "sysemu/numa.h"
@@ -1802,3 +1803,53 @@ build_hdr:
build_header(linker, tbl, (void *)(tbl->data + fadt_start),
"FACP", tbl->len - fadt_start, f->rev, oem_id, oem_table_id);
}
+
+void build_srat_hotpluggable_memory(GArray *table_data, uint64_t base,
+ uint64_t len, int default_node)
+{
+ MemoryDeviceInfoList *info_list = qmp_memory_device_list();
+ MemoryDeviceInfoList *info;
+ MemoryDeviceInfo *mi;
+ PCDIMMDeviceInfo *di;
+ uint64_t end = base + len, cur, size;
+ bool is_nvdimm;
+ AcpiSratMemoryAffinity *numamem;
+ MemoryAffinityFlags flags;
+
+ for (cur = base, info = info_list;
+ cur < end;
+ cur += size, info = info->next) {
+ numamem = acpi_data_push(table_data, sizeof *numamem);
+
+ if (!info) {
+ build_srat_memory(numamem, cur, end - cur, default_node,
+ MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
+ break;
+ }
+
+ mi = info->value;
+ is_nvdimm = (mi->type == MEMORY_DEVICE_INFO_KIND_NVDIMM);
+ di = !is_nvdimm ? mi->u.dimm.data : mi->u.nvdimm.data;
+
+ if (cur < di->addr) {
+ build_srat_memory(numamem, cur, di->addr - cur, default_node,
+ MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
+ numamem = acpi_data_push(table_data, sizeof *numamem);
+ }
+
+ size = di->size;
+
+ flags = MEM_AFFINITY_ENABLED;
+ if (di->hotpluggable) {
+ flags |= MEM_AFFINITY_HOTPLUGGABLE;
+ }
+ if (is_nvdimm) {
+ flags |= MEM_AFFINITY_NON_VOLATILE;
+ }
+
+ build_srat_memory(numamem, di->addr, size, di->node, flags);
+ }
+
+ qapi_free_MemoryDeviceInfoList(info_list);
+}
+
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index 6c36903c0a..4c2ca134ee 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -416,4 +416,7 @@ void build_slit(GArray *table_data, BIOSLinker *linker);
void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f,
const char *oem_id, const char *oem_table_id);
+
+void build_srat_hotpluggable_memory(GArray *table_data, uint64_t base,
+ uint64_t len, int default_node);
#endif
--
2.17.1
next prev parent reply other threads:[~2018-10-18 14:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 14:30 [Qemu-devel] [RFC v4 00/16] ARM virt: PCDIMM/NVDIMM at 2TB Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 01/16] hw/arm/boot: introduce fdt_add_memory_node helper Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 02/16] linux-headers: header update for KVM/ARM KVM_ARM_GET_MAX_VM_PHYS_SHIFT Eric Auger
2018-10-19 8:49 ` Suzuki K Poulose
2018-10-19 14:02 ` Auger Eric
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 03/16] hw/boards: Add a MachineState parameter to kvm_type callback Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 04/16] kvm: add kvm_arm_get_max_vm_phys_shift Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 05/16] vl: Set machine ram_size, maxram_size and ram_slots earlier Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 06/16] hw/arm/virt: Add virt-3.2 machine type Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 07/16] hw/arm/virt: Implement kvm_type function for 3.2 machine Eric Auger
2018-10-19 2:58 ` Richard Henderson
2018-10-19 13:59 ` Auger Eric
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 08/16] hw/arm/virt: Allocate device_memory Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 09/16] hw/arm/virt: Add memory hotplug framework Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 10/16] hw/arm/boot: Expose the PC-DIMM nodes in the DT Eric Auger
2018-10-18 14:30 ` Eric Auger [this message]
2019-01-21 11:44 ` [Qemu-devel] [RFC v4 11/16] acpi: move build_srat_hotpluggable_memory to generic ACPI source Shameerali Kolothum Thodi
2019-01-21 13:58 ` Auger Eric
2019-01-21 17:09 ` Shameerali Kolothum Thodi
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT Eric Auger
2018-10-22 13:40 ` Igor Mammedov
2018-11-05 13:27 ` Auger Eric
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 13/16] nvdimm: use configurable ACPI IO base and size Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 14/16] hw/arm/virt: Add nvdimm hot-plug infrastructure Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 15/16] hw/arm/boot: Expose the pmem nodes in the DT Eric Auger
2018-10-18 14:30 ` [Qemu-devel] [RFC v4 16/16] hw/arm/virt: Add nvdimm and nvdimm-persistence options Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018143042.29588-12-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=Suzuki.Poulose@arm.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=imammedo@redhat.com \
--cc=kwangwoo.lee@sk.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).