Re: [Qemu-devel] [PATCH v3 2/4] Introduce attributes to qemu timer subsystem

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

On Thu, Oct 18, 2018 at 05:04:29PM +0600, Artem Pisarenko wrote:
> Attributes are simple flags, associated with individual timers for their whole lifetime.
> They intended to be used to mark individual timers for special handling by various qemu features which have integration into qemu-timer.
> New/init functions family in timer interface updated and refactored (new 'attribute' argument added, timer_list replaced with timer_list_group+type combinations, comments improved to avoid info duplication).
> Also existing aio interface extended with attribute-enabled variants of functions, which create/initialize timers.
> 
> Signed-off-by: Artem Pisarenko <artem.k.pisarenko@gmail.com>
> ---
> 
> Notes:
>     v3:
>     - attributes has been properly incapsulated to qemu-timer (as suggested by Stefan Hajnoczi)
>     - attributes definition and docs refactored to avoid extra enum and use simple macros with explicit bit positions (as suggested by Stefan Hajnoczi and Paolo Bonzini)
>     - fixed old "QEMU_TIMER_ATTR(id)" notation (in comments) left from initial patch version
>     
>     v2:
>     - timer creation/initialize functions reworked and and their unnecessary variants removed (as Paolo Bonzini suggested)
>     - also their comments improved to avoid info duplication
> 
>  include/block/aio.h       |  59 ++++++++++++++++++++++---
>  include/qemu/timer.h      | 110 +++++++++++++++++++++++-----------------------
>  tests/ptimer-test-stubs.c |  13 ++++--
>  util/qemu-timer.c         |  13 ++++--
>  4 files changed, 125 insertions(+), 70 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]