From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Julia Suvorova <jusual@mail.ru>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
marcandre.lureau@redhat.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Joel Stanley" <joel@jms.id.au>,
"Jim Mussared" <jim@groklearning.com>,
"Steffen Görtz" <mail@steffen-goertz.de>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] chardev/char-socket: Function headers refactoring
Date: Fri, 19 Oct 2018 11:53:32 +0100 [thread overview]
Message-ID: <20181019105332.GI13722@redhat.com> (raw)
In-Reply-To: <20181018223501.21683-2-jusual@mail.ru>
On Fri, Oct 19, 2018 at 01:34:59AM +0300, Julia Suvorova wrote:
> Upcoming websocket support requires additional parameters in function
> headers that are already overloaded. This patch replaces the bunch of
> parameters with a single structure pointer.
>
> Signed-off-by: Julia Suvorova <jusual@mail.ru>
> ---
> chardev/char-socket.c | 55 +++++++++++++++++++++++--------------------
> 1 file changed, 30 insertions(+), 25 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-10-19 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 22:34 [Qemu-devel] [PATCH v3 0/3] chardev: Add websocket support Julia Suvorova
2018-10-18 22:34 ` [Qemu-devel] [PATCH v3 1/3] chardev/char-socket: Function headers refactoring Julia Suvorova
2018-10-19 10:15 ` Marc-André Lureau
2018-10-19 10:53 ` Daniel P. Berrangé [this message]
2018-10-18 22:35 ` [Qemu-devel] [PATCH v3 2/3] chardev: Add websocket support Julia Suvorova
2018-10-19 10:15 ` Marc-André Lureau
2018-10-19 10:59 ` Daniel P. Berrangé
2018-10-19 10:59 ` Daniel P. Berrangé
2018-10-18 22:35 ` [Qemu-devel] [PATCH v3 3/3] tests/test-char: Check websocket chardev functionality Julia Suvorova
2018-10-19 10:14 ` Marc-André Lureau
2018-10-19 11:02 ` Daniel P. Berrangé
2018-10-19 11:43 ` [Qemu-devel] [PATCH v3 0/3] chardev: Add websocket support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019105332.GI13722@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=jusual@mail.ru \
--cc=mail@steffen-goertz.de \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).