* [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG
@ 2018-10-19 11:00 Thomas Huth
2018-10-19 11:14 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2018-10-19 11:00 UTC (permalink / raw)
To: qemu-devel, Juan Quintela, Dr. David Alan Gilbert
Cc: Paolo Bonzini, Laurent Vivier, Emilio G. Cota, Peter Maydell,
Wei Huang, david, Cornelia Huck, Philippe Mathieu-Daudé
The migration test for s390x sometimes hangs when running with TCG,
similar to the problems that we have already observed with TCG for
the ppc64 guests. Thus disable the s390x test when we are not running
with KVM for now until the problem with TCG has been resolved.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/migration-test.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index b792025..06ca506 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -803,6 +803,22 @@ int main(int argc, char **argv)
return 0;
}
+ /*
+ * Similar to ppc64, s390x seems to be touchy with TCG, so disable it
+ * there until the problems are resolved
+ */
+ if (g_str_equal(qtest_get_arch(), "s390x")) {
+#if defined(HOST_S390X)
+ if (access("/dev/kvm", R_OK | W_OK)) {
+ g_test_message("Skipping test: kvm not available");
+ return 0;
+ }
+#else
+ g_test_message("Skipping test: Need s390x host to work properly");
+ return 0;
+#endif
+ }
+
tmpfs = mkdtemp(template);
if (!tmpfs) {
g_test_message("mkdtemp on path (%s): %s\n", template, strerror(errno));
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG
2018-10-19 11:00 [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG Thomas Huth
@ 2018-10-19 11:14 ` Laurent Vivier
2018-10-19 14:10 ` Emilio G. Cota
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Vivier @ 2018-10-19 11:14 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Juan Quintela, Dr. David Alan Gilbert
Cc: Paolo Bonzini, Emilio G. Cota, Peter Maydell, Wei Huang, david,
Cornelia Huck, Philippe Mathieu-Daudé
On 19/10/2018 13:00, Thomas Huth wrote:
> The migration test for s390x sometimes hangs when running with TCG,
> similar to the problems that we have already observed with TCG for
> the ppc64 guests. Thus disable the s390x test when we are not running
> with KVM for now until the problem with TCG has been resolved.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/migration-test.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index b792025..06ca506 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -803,6 +803,22 @@ int main(int argc, char **argv)
> return 0;
> }
>
> + /*
> + * Similar to ppc64, s390x seems to be touchy with TCG, so disable it
> + * there until the problems are resolved
> + */
> + if (g_str_equal(qtest_get_arch(), "s390x")) {
> +#if defined(HOST_S390X)
> + if (access("/dev/kvm", R_OK | W_OK)) {
> + g_test_message("Skipping test: kvm not available");
> + return 0;
> + }
> +#else
> + g_test_message("Skipping test: Need s390x host to work properly");
> + return 0;
> +#endif
> + }
> +
> tmpfs = mkdtemp(template);
> if (!tmpfs) {
> g_test_message("mkdtemp on path (%s): %s\n", template, strerror(errno));
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG
2018-10-19 11:14 ` Laurent Vivier
@ 2018-10-19 14:10 ` Emilio G. Cota
0 siblings, 0 replies; 3+ messages in thread
From: Emilio G. Cota @ 2018-10-19 14:10 UTC (permalink / raw)
To: Laurent Vivier
Cc: Thomas Huth, qemu-devel, Juan Quintela, Dr. David Alan Gilbert,
Paolo Bonzini, Peter Maydell, Wei Huang, david, Cornelia Huck,
Philippe Mathieu-Daudé
On Fri, Oct 19, 2018 at 13:14:57 +0200, Laurent Vivier wrote:
> On 19/10/2018 13:00, Thomas Huth wrote:
> > The migration test for s390x sometimes hangs when running with TCG,
> > similar to the problems that we have already observed with TCG for
> > the ppc64 guests. Thus disable the s390x test when we are not running
> > with KVM for now until the problem with TCG has been resolved.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Emilio G. Cota <cota@braap.org>
Thanks!
E.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-19 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-19 11:00 [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG Thomas Huth
2018-10-19 11:14 ` Laurent Vivier
2018-10-19 14:10 ` Emilio G. Cota
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).