From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: [Qemu-devel] [PATCH v2 7/9] iotests: 'new' module replacement in 169
Date: Fri, 19 Oct 2018 21:15:21 +0200 [thread overview]
Message-ID: <20181019191523.12157-8-mreitz@redhat.com> (raw)
In-Reply-To: <20181019191523.12157-1-mreitz@redhat.com>
iotest 169 uses the 'new' module to add methods to a class. This module
no longer exists in Python 3. Instead, we can use a lambda. Best of
all, this works in 2.7 just as well.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/qemu-iotests/169 | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/169
index f243db9955..e5614b159d 100755
--- a/tests/qemu-iotests/169
+++ b/tests/qemu-iotests/169
@@ -23,7 +23,6 @@ import iotests
import time
import itertools
import operator
-import new
from iotests import qemu_img
@@ -144,7 +143,7 @@ class TestDirtyBitmapMigration(iotests.QMPTestCase):
def inject_test_case(klass, name, method, *args, **kwargs):
mc = operator.methodcaller(method, *args, **kwargs)
- setattr(klass, 'test_' + name, new.instancemethod(mc, None, klass))
+ setattr(klass, 'test_' + name, lambda self: mc(self))
for cmb in list(itertools.product((True, False), repeat=4)):
name = ('_' if cmb[0] else '_not_') + 'persistent_'
--
2.17.1
next prev parent reply other threads:[~2018-10-19 19:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 19:15 [Qemu-devel] [PATCH v2 0/9] iotests: Make them work for both Python 2 and 3 Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 1/9] iotests: Make nbd-fault-injector flush Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 2/9] iotests: Flush in iotests.py's QemuIoInteractive Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 3/9] iotests: Use Python byte strings where appropriate Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 4/9] iotests: Use // for Python integer division Max Reitz
2018-10-19 20:01 ` Eduardo Habkost
2018-10-20 0:19 ` Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 5/9] iotests: Different iterator behavior in Python 3 Max Reitz
2018-10-19 20:01 ` Eduardo Habkost
2018-10-20 0:53 ` Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 6/9] iotests: Explicitly inherit FDs in Python Max Reitz
2018-10-19 20:07 ` Eduardo Habkost
2018-10-20 0:54 ` Cleber Rosa
2018-10-19 19:15 ` Max Reitz [this message]
2018-10-20 0:54 ` [Qemu-devel] [PATCH v2 7/9] iotests: 'new' module replacement in 169 Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 8/9] iotests: Modify imports for Python 3 Max Reitz
2018-10-19 20:11 ` Eduardo Habkost
2018-10-20 0:58 ` Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 9/9] iotests: Unify log outputs between Python 2 and 3 Max Reitz
2018-10-20 0:59 ` Cleber Rosa
2018-10-20 1:00 ` [Qemu-devel] [PATCH v2 0/9] iotests: Make them work for both " Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019191523.12157-8-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).