From: "Michael S. Tsirkin" <mst@redhat.com>
To: Li Qiang <liq3ea@163.com>
Cc: marcel.apfelbaum@gmail.com, philmd@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link
Date: Tue, 23 Oct 2018 18:47:02 -0400 [thread overview]
Message-ID: <20181023184621-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20181011161820.38794-1-liq3ea@163.com>
On Thu, Oct 11, 2018 at 09:18:20AM -0700, Li Qiang wrote:
> Seems the intel link is unavailable, change it to qemu site.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
BTW you need to fix up your setup: patches you sent confuse git
am and other tools. Somethig to do with encoding.
> ---
> hw/pci-host/piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..56a42055f1 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -40,7 +40,7 @@
>
> /*
> * I440FX chipset data sheet.
> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> + * https://wiki.qemu.org/File:29054901.pdf
> */
>
> #define I440FX_PCI_HOST_BRIDGE(obj) \
> --
> 2.17.1
>
>
prev parent reply other threads:[~2018-10-23 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 16:18 [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link Li Qiang
2018-10-11 17:14 ` Markus Armbruster
2018-10-18 13:41 ` Marcel Apfelbaum
2018-10-18 15:48 ` Philippe Mathieu-Daudé
2018-10-23 22:47 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023184621-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=liq3ea@163.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).