* [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link
@ 2018-10-11 16:18 Li Qiang
2018-10-11 17:14 ` Markus Armbruster
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Li Qiang @ 2018-10-11 16:18 UTC (permalink / raw)
To: mst, marcel.apfelbaum; +Cc: qemu-devel, philmd, Li Qiang
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 602 bytes --]
Seems the intel link is unavailable, change it to qemu site.
Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/pci-host/piix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0e608347c1..56a42055f1 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -40,7 +40,7 @@
/*
* I440FX chipset data sheet.
- * http://download.intel.com/design/chipsets/datashts/29054901.pdf
+ * https://wiki.qemu.org/File:29054901.pdf
*/
#define I440FX_PCI_HOST_BRIDGE(obj) \
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link
2018-10-11 16:18 [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link Li Qiang
@ 2018-10-11 17:14 ` Markus Armbruster
2018-10-18 13:41 ` Marcel Apfelbaum
2018-10-23 22:47 ` Michael S. Tsirkin
2 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2018-10-11 17:14 UTC (permalink / raw)
To: Li Qiang; +Cc: mst, marcel.apfelbaum, philmd, qemu-devel
Li Qiang <liq3ea@163.com> writes:
> Seems the intel link is unavailable, change it to qemu site.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> Reviewed-by: Philippe Mathieu-Daud© <philmd@redhat.com>
Mojibake. Perhaps the maintainer is willing to correct it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link
2018-10-11 16:18 [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link Li Qiang
2018-10-11 17:14 ` Markus Armbruster
@ 2018-10-18 13:41 ` Marcel Apfelbaum
2018-10-18 15:48 ` Philippe Mathieu-Daudé
2018-10-23 22:47 ` Michael S. Tsirkin
2 siblings, 1 reply; 5+ messages in thread
From: Marcel Apfelbaum @ 2018-10-18 13:41 UTC (permalink / raw)
To: Li Qiang, mst; +Cc: qemu-devel, philmd
On 10/11/18 7:18 PM, Li Qiang wrote:
> Seems the intel link is unavailable, change it to qemu site.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/pci-host/piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..56a42055f1 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -40,7 +40,7 @@
>
> /*
> * I440FX chipset data sheet.
> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> + * https://wiki.qemu.org/File:29054901.pdf
> */
>
Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
Thanks,
Marcel
> #define I440FX_PCI_HOST_BRIDGE(obj) \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link
2018-10-18 13:41 ` Marcel Apfelbaum
@ 2018-10-18 15:48 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-18 15:48 UTC (permalink / raw)
To: Marcel Apfelbaum, Li Qiang, mst; +Cc: qemu-devel
On 18/10/2018 15:41, Marcel Apfelbaum wrote:
>
>
> On 10/11/18 7:18 PM, Li Qiang wrote:
>> Seems the intel link is unavailable, change it to qemu site.
>>
>> Signed-off-by: Li Qiang <liq3ea@163.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> hw/pci-host/piix.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
>> index 0e608347c1..56a42055f1 100644
>> --- a/hw/pci-host/piix.c
>> +++ b/hw/pci-host/piix.c
>> @@ -40,7 +40,7 @@
>> /*
>> * I440FX chipset data sheet.
>> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
>> + * https://wiki.qemu.org/File:29054901.pdf
>> */
>>
>
> Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
Perhaps the maintainer can add a space before your email.
>
> Thanks,
> Marcel
>
>> #define I440FX_PCI_HOST_BRIDGE(obj) \
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link
2018-10-11 16:18 [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link Li Qiang
2018-10-11 17:14 ` Markus Armbruster
2018-10-18 13:41 ` Marcel Apfelbaum
@ 2018-10-23 22:47 ` Michael S. Tsirkin
2 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2018-10-23 22:47 UTC (permalink / raw)
To: Li Qiang; +Cc: marcel.apfelbaum, philmd, qemu-devel
On Thu, Oct 11, 2018 at 09:18:20AM -0700, Li Qiang wrote:
> Seems the intel link is unavailable, change it to qemu site.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
BTW you need to fix up your setup: patches you sent confuse git
am and other tools. Somethig to do with encoding.
> ---
> hw/pci-host/piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..56a42055f1 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -40,7 +40,7 @@
>
> /*
> * I440FX chipset data sheet.
> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> + * https://wiki.qemu.org/File:29054901.pdf
> */
>
> #define I440FX_PCI_HOST_BRIDGE(obj) \
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-23 22:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 16:18 [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link Li Qiang
2018-10-11 17:14 ` Markus Armbruster
2018-10-18 13:41 ` Marcel Apfelbaum
2018-10-18 15:48 ` Philippe Mathieu-Daudé
2018-10-23 22:47 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).