* [Qemu-devel] [PATCH] hw/arm/virt: Set VIRT_COMPAT_3_0 compat
@ 2018-10-24 8:56 Eric Auger
2018-10-24 11:25 ` Andrew Jones
0 siblings, 1 reply; 3+ messages in thread
From: Eric Auger @ 2018-10-24 8:56 UTC (permalink / raw)
To: eric.auger.pro, eric.auger, qemu-devel, qemu-arm, peter.maydell; +Cc: drjones
We are missing the VIRT_COMPAT_3_0 definition and setting.
Let's add them.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
hw/arm/virt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 9f677825f9..a2b8d8f7c2 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1871,6 +1871,9 @@ static void virt_machine_3_1_options(MachineClass *mc)
}
DEFINE_VIRT_MACHINE_AS_LATEST(3, 1)
+#define VIRT_COMPAT_3_0 \
+ HW_COMPAT_3_0
+
static void virt_3_0_instance_init(Object *obj)
{
virt_3_1_instance_init(obj);
@@ -1879,6 +1882,7 @@ static void virt_3_0_instance_init(Object *obj)
static void virt_machine_3_0_options(MachineClass *mc)
{
virt_machine_3_1_options(mc);
+ SET_MACHINE_COMPAT(mc, VIRT_COMPAT_3_0);
}
DEFINE_VIRT_MACHINE(3, 0)
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm/virt: Set VIRT_COMPAT_3_0 compat
2018-10-24 8:56 [Qemu-devel] [PATCH] hw/arm/virt: Set VIRT_COMPAT_3_0 compat Eric Auger
@ 2018-10-24 11:25 ` Andrew Jones
2018-10-29 13:09 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jones @ 2018-10-24 11:25 UTC (permalink / raw)
To: Eric Auger; +Cc: eric.auger.pro, qemu-devel, qemu-arm, peter.maydell
On Wed, Oct 24, 2018 at 10:56:02AM +0200, Eric Auger wrote:
> We are missing the VIRT_COMPAT_3_0 definition and setting.
> Let's add them.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
> hw/arm/virt.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 9f677825f9..a2b8d8f7c2 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1871,6 +1871,9 @@ static void virt_machine_3_1_options(MachineClass *mc)
> }
> DEFINE_VIRT_MACHINE_AS_LATEST(3, 1)
>
> +#define VIRT_COMPAT_3_0 \
> + HW_COMPAT_3_0
> +
> static void virt_3_0_instance_init(Object *obj)
> {
> virt_3_1_instance_init(obj);
> @@ -1879,6 +1882,7 @@ static void virt_3_0_instance_init(Object *obj)
> static void virt_machine_3_0_options(MachineClass *mc)
> {
> virt_machine_3_1_options(mc);
> + SET_MACHINE_COMPAT(mc, VIRT_COMPAT_3_0);
> }
> DEFINE_VIRT_MACHINE(3, 0)
>
> --
> 2.17.2
>
>
Oops, I should have done this with the 3.1 machine type. Thanks for the
catching and patching.
Reviewed-by: Andrew Jones <drjones@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm/virt: Set VIRT_COMPAT_3_0 compat
2018-10-24 11:25 ` Andrew Jones
@ 2018-10-29 13:09 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2018-10-29 13:09 UTC (permalink / raw)
To: Andrew Jones; +Cc: Eric Auger, Eric Auger, QEMU Developers, qemu-arm
On 24 October 2018 at 12:25, Andrew Jones <drjones@redhat.com> wrote:
> On Wed, Oct 24, 2018 at 10:56:02AM +0200, Eric Auger wrote:
>> We are missing the VIRT_COMPAT_3_0 definition and setting.
>> Let's add them.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>> hw/arm/virt.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>> index 9f677825f9..a2b8d8f7c2 100644
>> --- a/hw/arm/virt.c
>> +++ b/hw/arm/virt.c
>> @@ -1871,6 +1871,9 @@ static void virt_machine_3_1_options(MachineClass *mc)
>> }
>> DEFINE_VIRT_MACHINE_AS_LATEST(3, 1)
>>
>> +#define VIRT_COMPAT_3_0 \
>> + HW_COMPAT_3_0
>> +
>> static void virt_3_0_instance_init(Object *obj)
>> {
>> virt_3_1_instance_init(obj);
>> @@ -1879,6 +1882,7 @@ static void virt_3_0_instance_init(Object *obj)
>> static void virt_machine_3_0_options(MachineClass *mc)
>> {
>> virt_machine_3_1_options(mc);
>> + SET_MACHINE_COMPAT(mc, VIRT_COMPAT_3_0);
>> }
>> DEFINE_VIRT_MACHINE(3, 0)
>>
>> --
>> 2.17.2
>>
>>
>
> Oops, I should have done this with the 3.1 machine type. Thanks for the
> catching and patching.
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-29 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-24 8:56 [Qemu-devel] [PATCH] hw/arm/virt: Set VIRT_COMPAT_3_0 compat Eric Auger
2018-10-24 11:25 ` Andrew Jones
2018-10-29 13:09 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).