qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	peterx@redhat.com, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/6] monitor: inline ambiguous helper functions
Date: Mon, 29 Oct 2018 16:57:28 +0400	[thread overview]
Message-ID: <20181029125733.14597-2-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20181029125733.14597-1-marcandre.lureau@redhat.com>

The function were not named with "mon_iothread", or following the AIO
vs GMainContext distinction. Inline them instead.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 monitor.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/monitor.c b/monitor.c
index 823b5a1099..07712d89f9 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4448,16 +4448,6 @@ static void sortcmdlist(void)
     qsort((void *)info_cmds, array_num, elem_size, compare_mon_cmd);
 }
 
-static GMainContext *monitor_get_io_context(void)
-{
-    return iothread_get_g_main_context(mon_iothread);
-}
-
-static AioContext *monitor_get_aio_context(void)
-{
-    return iothread_get_aio_context(mon_iothread);
-}
-
 static void monitor_iothread_init(void)
 {
     mon_iothread = iothread_create("mon_iothread", &error_abort);
@@ -4545,7 +4535,7 @@ static void monitor_qmp_setup_handlers_bh(void *opaque)
     GMainContext *context;
 
     assert(mon->use_io_thread);
-    context = monitor_get_io_context();
+    context = iothread_get_g_main_context(mon_iothread);
     assert(context);
     qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, monitor_qmp_read,
                              monitor_qmp_event, NULL, mon, context, true);
@@ -4597,7 +4587,7 @@ void monitor_init(Chardev *chr, int flags)
              * since chardev might be running in the monitor I/O
              * thread.  Schedule a bottom half.
              */
-            aio_bh_schedule_oneshot(monitor_get_aio_context(),
+            aio_bh_schedule_oneshot(iothread_get_aio_context(mon_iothread),
                                     monitor_qmp_setup_handlers_bh, mon);
             /* The bottom half will add @mon to @mon_list */
             return;
-- 
2.19.0.271.gfe8321ec05

  reply	other threads:[~2018-10-29 12:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 12:57 [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes Marc-André Lureau
2018-10-29 12:57 ` Marc-André Lureau [this message]
2018-10-30  3:33   ` [Qemu-devel] [PATCH v2 1/6] monitor: inline ambiguous helper functions Peter Xu
2018-12-03  6:58   ` Markus Armbruster
2018-10-29 12:57 ` [Qemu-devel] [PATCH v2 2/6] monitor: accept chardev input from iothread Marc-André Lureau
2018-10-30  3:43   ` Peter Xu
2018-12-03  7:10   ` Markus Armbruster
2018-12-03  8:04     ` Marc-André Lureau
2018-12-03  9:29       ` Markus Armbruster
2018-10-29 12:57 ` [Qemu-devel] [PATCH v2 3/6] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag Marc-André Lureau
2018-12-03  7:20   ` Markus Armbruster
2018-12-03  8:11     ` Marc-André Lureau
2018-10-29 12:57 ` [Qemu-devel] [PATCH v2 4/6] monitor: check if chardev can switch gcontext for OOB Marc-André Lureau
2018-12-03  8:23   ` Markus Armbruster
2018-12-03  8:44     ` Marc-André Lureau
2018-10-29 12:57 ` [Qemu-devel] [PATCH v2 5/6] monitor: prevent inserting new monitors after cleanup Marc-André Lureau
2018-10-30  5:42   ` Peter Xu
2018-12-03  8:59   ` Markus Armbruster
2018-12-03  9:55     ` Marc-André Lureau
2018-12-03 12:16       ` Markus Armbruster
2018-10-29 12:57 ` [Qemu-devel] [PATCH v2 6/6] monitor: avoid potential dead-lock when cleaning up Marc-André Lureau
2018-12-03  9:26   ` Markus Armbruster
2018-12-03 10:02     ` Marc-André Lureau
2018-12-03 12:17       ` Markus Armbruster
2018-10-30  5:48 ` [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes Peter Xu
2018-10-30  8:06   ` Marc-André Lureau
2018-10-30 17:56 ` Markus Armbruster
2018-12-03  9:36 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029125733.14597-2-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).