qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: Yang Zhong <yang.zhong@intel.com>
Subject: [Qemu-devel] [PATCH v2 14/19] hw: acpi: Fix memory hotplug AML generation error
Date: Mon, 29 Oct 2018 17:24:36 +0100	[thread overview]
Message-ID: <20181029162441.31631-15-sameo@linux.intel.com> (raw)
In-Reply-To: <20181029162441.31631-1-sameo@linux.intel.com>

From: Yang Zhong <yang.zhong@intel.com>

When using the generated memory hotplug AML, the iasl
compiler would give the following error:

dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2))
Error 6080 - Called method returns no value ^

Signed-off-by: Yang Zhong <yang.zhong@intel.com>
---
 hw/acpi/memory_hotplug.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
index db2c4df961..893fc2bd27 100644
--- a/hw/acpi/memory_hotplug.c
+++ b/hw/acpi/memory_hotplug.c
@@ -686,15 +686,15 @@ void build_memory_hotplug_aml(Aml *table, uint32_t nr_mem,
 
             method = aml_method("_OST", 3, AML_NOTSERIALIZED);
             s = MEMORY_SLOT_OST_METHOD;
-            aml_append(method, aml_return(aml_call4(
-                s, aml_name("_UID"), aml_arg(0), aml_arg(1), aml_arg(2)
-            )));
+            aml_append(method,
+                       aml_call4(s, aml_name("_UID"), aml_arg(0),
+                                 aml_arg(1), aml_arg(2)));
             aml_append(dev, method);
 
             method = aml_method("_EJ0", 1, AML_NOTSERIALIZED);
             s = MEMORY_SLOT_EJECT_METHOD;
-            aml_append(method, aml_return(aml_call2(
-                       s, aml_name("_UID"), aml_arg(0))));
+            aml_append(method,
+                       aml_call2(s, aml_name("_UID"), aml_arg(0)));
             aml_append(dev, method);
 
             aml_append(dev_container, dev);
-- 
2.17.2

  parent reply	other threads:[~2018-10-29 16:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 16:24 [Qemu-devel] [PATCH v2 00/19] ACPI reorganization for hardware-reduced support Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 01/19] hw: i386: Decouple the ACPI build from the PC machine type Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 02/19] hw: acpi: Export ACPI build alignment API Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 03/19] hw: acpi: Export the RSDP build API Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 04/19] hw: acpi: Implement XSDT support for RSDP Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 05/19] hw: arm: Switch to the AML build RSDP building routine Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 06/19] hw: acpi: Generalize AML build routines Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 07/19] hw: acpi: Factorize _OSC AML across architectures Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 08/19] hw: i386: Refactor PCI host getter Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 09/19] hw: acpi: Export and generalize the PCI host AML API Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 10/19] hw: acpi: Export the MCFG getter Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 11/19] hw: acpi: Do not create hotplug method when handler is not defined Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 12/19] hw: i386: Make the hotpluggable memory size property more generic Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 13/19] hw: acpi: Export the SRAT AML build API Samuel Ortiz
2018-10-29 16:24 ` Samuel Ortiz [this message]
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 15/19] hw: acpi: Export the PCI hotplug API Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 16/19] hw: acpi: Retrieve the PCI bus from AcpiPciHpState Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 17/19] hw: acpi: Define ACPI tables builder interface Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 18/19] hw: i386: Export the MADT build method Samuel Ortiz
2018-10-29 16:24 ` [Qemu-devel] [PATCH v2 19/19] hw: i386: Implement the ACPI builder interface for PC Samuel Ortiz
2018-10-29 16:51 ` [Qemu-devel] [PATCH v2 00/19] ACPI reorganization for hardware-reduced support Samuel Ortiz
2018-10-29 17:28 ` Markus Armbruster
2018-10-30 15:20   ` Samuel Ortiz
2018-10-30 16:21     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029162441.31631-15-sameo@linux.intel.com \
    --to=sameo@linux.intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yang.zhong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).