qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: jsnow@redhat.com, peter.maydell@linaro.org,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: [Qemu-devel] [PULL 03/19] dirty-bitmap: rename bdrv_undo_clear_dirty_bitmap
Date: Mon, 29 Oct 2018 17:24:45 -0400	[thread overview]
Message-ID: <20181029212501.5897-4-jsnow@redhat.com> (raw)
In-Reply-To: <20181029212501.5897-1-jsnow@redhat.com>

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Use more generic names to reuse the function for bitmap merge in the
following commit.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 block/dirty-bitmap.c      | 4 ++--
 blockdev.c                | 2 +-
 include/block/block_int.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 6c8761e027..017ee9db46 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -633,12 +633,12 @@ void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap **out)
     bdrv_dirty_bitmap_unlock(bitmap);
 }
 
-void bdrv_undo_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *in)
+void bdrv_restore_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *backup)
 {
     HBitmap *tmp = bitmap->bitmap;
     assert(bdrv_dirty_bitmap_enabled(bitmap));
     assert(!bdrv_dirty_bitmap_readonly(bitmap));
-    bitmap->bitmap = in;
+    bitmap->bitmap = backup;
     hbitmap_free(tmp);
 }
 
diff --git a/blockdev.c b/blockdev.c
index e3398e141a..598ff87519 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2033,7 +2033,7 @@ static void block_dirty_bitmap_clear_abort(BlkActionState *common)
                                              common, common);
 
     if (state->backup) {
-        bdrv_undo_clear_dirty_bitmap(state->bitmap, state->backup);
+        bdrv_restore_dirty_bitmap(state->bitmap, state->backup);
     }
 }
 
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 92ecbd866e..f605622216 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -1155,7 +1155,7 @@ bool blk_dev_is_medium_locked(BlockBackend *blk);
 void bdrv_set_dirty(BlockDriverState *bs, int64_t offset, int64_t bytes);
 
 void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap **out);
-void bdrv_undo_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *in);
+void bdrv_restore_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *backup);
 
 void bdrv_inc_in_flight(BlockDriverState *bs);
 void bdrv_dec_in_flight(BlockDriverState *bs);
-- 
2.14.5

  parent reply	other threads:[~2018-10-29 21:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 21:24 [Qemu-devel] [PULL 00/19] Bitmaps patches John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 01/19] blockdev-backup: add bitmap argument John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 02/19] dirty-bitmap: switch assert-fails to errors in bdrv_merge_dirty_bitmap John Snow
2018-10-29 21:24 ` John Snow [this message]
2018-10-29 21:24 ` [Qemu-devel] [PULL 04/19] dirty-bitmap: make it possible to restore bitmap after merge John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 05/19] blockdev: rename block-dirty-bitmap-clear transaction handlers John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 06/19] qapi: add transaction support for x-block-dirty-bitmap-merge John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 07/19] iotests: 169: drop deprecated 'autoload' parameter John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 08/19] block/qcow2: improve error message in qcow2_inactivate John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 09/19] bloc/qcow2: drop dirty_bitmaps_loaded state variable John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 10/19] block/dirty-bitmaps: add user_locked status checker John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 11/19] block/dirty-bitmaps: fix merge permissions John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 12/19] block/dirty-bitmaps: allow clear on disabled bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 13/19] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 14/19] block/backup: prohibit backup from using in use bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 15/19] nbd: forbid use of frozen bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 16/19] bitmap: Update count after a merge John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 17/19] dirty-bitmaps: clean-up bitmaps loading and migration logic John Snow
2018-10-29 21:25 ` [Qemu-devel] [PULL 18/19] iotests: improve 169 John Snow
2018-10-29 21:25 ` [Qemu-devel] [PULL 19/19] iotests: 169: add cases for source vm resuming John Snow
2018-10-30 15:49 ` [Qemu-devel] [PULL 00/19] Bitmaps patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029212501.5897-4-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).