From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: jsnow@redhat.com, peter.maydell@linaro.org,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: [Qemu-devel] [PULL 05/19] blockdev: rename block-dirty-bitmap-clear transaction handlers
Date: Mon, 29 Oct 2018 17:24:47 -0400 [thread overview]
Message-ID: <20181029212501.5897-6-jsnow@redhat.com> (raw)
In-Reply-To: <20181029212501.5897-1-jsnow@redhat.com>
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Rename block-dirty-bitmap-clear transaction handlers to reuse them for
x-block-dirty-bitmap-merge transaction in the following patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
blockdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index b8a854fba5..d7776cbd4c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2027,7 +2027,7 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common,
bdrv_clear_dirty_bitmap(state->bitmap, &state->backup);
}
-static void block_dirty_bitmap_clear_abort(BlkActionState *common)
+static void block_dirty_bitmap_restore(BlkActionState *common)
{
BlockDirtyBitmapState *state = DO_UPCAST(BlockDirtyBitmapState,
common, common);
@@ -2037,7 +2037,7 @@ static void block_dirty_bitmap_clear_abort(BlkActionState *common)
}
}
-static void block_dirty_bitmap_clear_commit(BlkActionState *common)
+static void block_dirty_bitmap_free_backup(BlkActionState *common)
{
BlockDirtyBitmapState *state = DO_UPCAST(BlockDirtyBitmapState,
common, common);
@@ -2171,8 +2171,8 @@ static const BlkActionOps actions[] = {
[TRANSACTION_ACTION_KIND_BLOCK_DIRTY_BITMAP_CLEAR] = {
.instance_size = sizeof(BlockDirtyBitmapState),
.prepare = block_dirty_bitmap_clear_prepare,
- .commit = block_dirty_bitmap_clear_commit,
- .abort = block_dirty_bitmap_clear_abort,
+ .commit = block_dirty_bitmap_free_backup,
+ .abort = block_dirty_bitmap_restore,
},
[TRANSACTION_ACTION_KIND_X_BLOCK_DIRTY_BITMAP_ENABLE] = {
.instance_size = sizeof(BlockDirtyBitmapState),
--
2.14.5
next prev parent reply other threads:[~2018-10-29 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 21:24 [Qemu-devel] [PULL 00/19] Bitmaps patches John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 01/19] blockdev-backup: add bitmap argument John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 02/19] dirty-bitmap: switch assert-fails to errors in bdrv_merge_dirty_bitmap John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 03/19] dirty-bitmap: rename bdrv_undo_clear_dirty_bitmap John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 04/19] dirty-bitmap: make it possible to restore bitmap after merge John Snow
2018-10-29 21:24 ` John Snow [this message]
2018-10-29 21:24 ` [Qemu-devel] [PULL 06/19] qapi: add transaction support for x-block-dirty-bitmap-merge John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 07/19] iotests: 169: drop deprecated 'autoload' parameter John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 08/19] block/qcow2: improve error message in qcow2_inactivate John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 09/19] bloc/qcow2: drop dirty_bitmaps_loaded state variable John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 10/19] block/dirty-bitmaps: add user_locked status checker John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 11/19] block/dirty-bitmaps: fix merge permissions John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 12/19] block/dirty-bitmaps: allow clear on disabled bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 13/19] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 14/19] block/backup: prohibit backup from using in use bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 15/19] nbd: forbid use of frozen bitmaps John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 16/19] bitmap: Update count after a merge John Snow
2018-10-29 21:24 ` [Qemu-devel] [PULL 17/19] dirty-bitmaps: clean-up bitmaps loading and migration logic John Snow
2018-10-29 21:25 ` [Qemu-devel] [PULL 18/19] iotests: improve 169 John Snow
2018-10-29 21:25 ` [Qemu-devel] [PULL 19/19] iotests: 169: add cases for source vm resuming John Snow
2018-10-30 15:49 ` [Qemu-devel] [PULL 00/19] Bitmaps patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029212501.5897-6-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).