From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Eric Blake" <eblake@redhat.com>,
qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
"Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PATCH 2/4] add QemuSupportState to DeviceClass
Date: Tue, 30 Oct 2018 12:13:46 +0100 [thread overview]
Message-ID: <20181030111348.14713-3-kraxel@redhat.com> (raw)
In-Reply-To: <20181030111348.14713-1-kraxel@redhat.com>
So we can tag device support state.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/hw/qdev-core.h | 2 ++
hw/core/qdev.c | 8 +++++++-
qdev-monitor.c | 7 +++++++
3 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index a24d0dd566..ff6bd3f08f 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -3,6 +3,7 @@
#include "qemu/queue.h"
#include "qemu/bitmap.h"
+#include "qemu/support-state.h"
#include "qom/object.h"
#include "hw/irq.h"
#include "hw/hotplug.h"
@@ -105,6 +106,7 @@ typedef struct DeviceClass {
*/
bool user_creatable;
bool hotpluggable;
+ QemuSupportState supported;
/* callbacks */
DeviceReset reset;
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 6b3cc55b27..e788fca257 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -133,11 +133,17 @@ DeviceState *qdev_create(BusState *bus, const char *name)
DeviceState *qdev_try_create(BusState *bus, const char *type)
{
+ DeviceClass *dc;
DeviceState *dev;
- if (object_class_by_name(type) == NULL) {
+ dc = DEVICE_CLASS(object_class_by_name(type));
+ if (dc == NULL) {
return NULL;
}
+ if (qemu_is_deprecated(&dc->supported) ||
+ qemu_is_obsolete(&dc->supported)) {
+ qemu_warn_support_state("device", type, &dc->supported);
+ }
dev = DEVICE(object_new(type));
if (!dev) {
return NULL;
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 802c18a74e..63cb43691c 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -128,6 +128,9 @@ static void qdev_print_devinfo(DeviceClass *dc)
if (!dc->user_creatable) {
out_printf(", no-user");
}
+ if (dc->supported.state != SUPPORT_STATE_UNKNOWN) {
+ out_printf(", %s", SupportState_str(dc->supported.state));
+ }
out_printf("\n");
}
@@ -579,6 +582,10 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **errp)
if (!dc) {
return NULL;
}
+ if (qemu_is_deprecated(&dc->supported) ||
+ qemu_is_obsolete(&dc->supported)) {
+ qemu_warn_support_state("device", driver, &dc->supported);
+ }
/* find bus */
path = qemu_opt_get(opts, "bus");
--
2.9.3
next prev parent reply other threads:[~2018-10-30 11:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 11:13 [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState Gerd Hoffmann
2018-10-30 11:13 ` [Qemu-devel] [PATCH 1/4] add QemuSupportState Gerd Hoffmann
2018-10-30 13:32 ` Philippe Mathieu-Daudé
2018-10-30 14:00 ` Gerd Hoffmann
2018-10-30 14:13 ` Philippe Mathieu-Daudé
2018-10-30 15:46 ` Cornelia Huck
2018-10-30 17:37 ` Philippe Mathieu-Daudé
2018-10-30 23:15 ` Eduardo Habkost
2018-10-31 9:22 ` Cornelia Huck
2018-11-05 7:30 ` Gerd Hoffmann
2018-11-05 13:49 ` Eduardo Habkost
2018-11-06 6:56 ` Gerd Hoffmann
2018-10-31 16:04 ` John Snow
2018-10-31 18:06 ` Eduardo Habkost
2018-10-31 18:37 ` John Snow
2018-10-31 18:58 ` Eduardo Habkost
2018-10-31 20:05 ` John Snow
2018-11-05 7:46 ` Gerd Hoffmann
2018-10-30 14:54 ` Eduardo Habkost
2018-10-30 15:02 ` Eduardo Habkost
2018-10-30 17:30 ` [Qemu-devel] [Qemu-ppc] " Murilo Opsfelder Araujo
2018-10-30 11:13 ` Gerd Hoffmann [this message]
2018-10-30 11:13 ` [Qemu-devel] [PATCH 3/4] tag cirrus as obsolete Gerd Hoffmann
2018-10-30 11:22 ` Paolo Bonzini
2018-10-30 11:13 ` [Qemu-devel] [PATCH 4/4] switch machine types to QemuSupportState Gerd Hoffmann
2018-10-30 11:22 ` [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState Paolo Bonzini
2018-10-30 14:34 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030111348.14713-3-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).