Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

[Gerd Hoffmann <kraxel@redhat.com>]

On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Gerd,
> 
> On 30/10/18 12:13, Gerd Hoffmann wrote:
> > Indicates support state for somerhing (device, backend, subsystem, ...)
> 
> "something"

Oops, I'll fix.

> > +##
> > +# @SupportState:
> > +#
> > +# Indicate Support level of qemu devices, backends, subsystems, ...
> > +#
> > +# Since: 3.2
> > +##
> > +{ 'enum': 'SupportState',
> > +  'data': [ 'unknown',
> 
> 'unknown' is scary and should be fixed.

'unknown' maps to "0" due to being first in list, so this is what you
get when it isn't explicitly set to something else.  Which make sense
IMHO.

> > +            'supported',
> > +            'maintained',
> > +            'odd-fixes',
> 
> All those fit in 'supported'
> 
> > +            'orphan',
> > +            'obsolete',
> > +            'deprecated' ] }
> 
> And all those should appear as 'deprecated' IMHO.

See minutes on deprecation discussion.  Seems there is agreement we
need something more finegrained than "supported" and "deprecated".

cheers,
  Gerd