qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 23/24] qga-win: report specific error when failing to open channel
Date: Tue, 30 Oct 2018 09:43:57 -0500	[thread overview]
Message-ID: <20181030144358.23144-24-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <20181030144358.23144-1-mdroth@linux.vnet.ibm.com>

Useful in general, but especially now that errors might occur more
frequently with --retry-path set.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qga/channel-win32.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/qga/channel-win32.c b/qga/channel-win32.c
index b3597a8a0f..c86f4388db 100644
--- a/qga/channel-win32.c
+++ b/qga/channel-win32.c
@@ -302,7 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannelMethod method,
                            OPEN_EXISTING,
                            FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, NULL);
     if (c->handle == INVALID_HANDLE_VALUE) {
-        g_critical("error opening path %s", newpath);
+        g_critical("error opening path %s: %s", newpath,
+                   g_win32_error_message(GetLastError()));
         return false;
     }
 
-- 
2.17.1

  parent reply	other threads:[~2018-10-30 14:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 14:43 [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 01/24] qga: Support Unicode paths in guest-file-open on win32 Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 02/24] qga-win: add support for qmp_guest_fsfreeze_freeze_list Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 03/24] qga: ignore non present cpus when handling qmp_guest_get_vcpus() Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 04/24] configure: add test for libudev Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 05/24] qga: linux: report disk serial number Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 06/24] qga: linux: return disk device in guest-get-fsinfo Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 07/24] qga-win: prevent crash when executing fsinfo command Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 08/24] qga-win: fsinfo: pci-info: allow partial info Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 09/24] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 10/24] qga-win: add debugging information Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 11/24] qga-win: refactor disk properties (bus) Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 12/24] qga-win: report disk serial number Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 13/24] qga-win: refactor disk info Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 14/24] qga-win: handle multi-disk volumes Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 15/24] qga-win: return disk device in guest-get-fsinfo Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 16/24] qga-win: demystify namespace stripping Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 17/24] qga: fix an off-by-one issue Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 18/24] qga: group agent init/cleanup init separate routines Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 19/24] qga: hang GAConfig/socket_activation off of GAState global Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 20/24] qga: move w32 service handling out of run_agent() Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 21/24] qga: add --retry-path option for re-initializing channel on failure Michael Roth
2018-10-30 14:43 ` [Qemu-devel] [PULL 22/24] qga-win: install service with --retry-path set by default Michael Roth
2018-10-30 14:43 ` Michael Roth [this message]
2018-10-30 14:43 ` [Qemu-devel] [PULL 24/24] qga-win: changing --retry-path option behavior Michael Roth
2018-10-30 18:49 ` [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze Peter Maydell
2018-10-30 20:57   ` Michael Roth
2018-10-31 13:23     ` Peter Maydell
2018-10-31 13:59       ` Michael Roth
2018-10-31 15:41 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181030144358.23144-24-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).