From: Eduardo Habkost <ehabkost@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Eric Blake" <eblake@redhat.com>,
qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
"Markus Armbruster" <armbru@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState
Date: Tue, 30 Oct 2018 12:02:00 -0300 [thread overview]
Message-ID: <20181030150200.GW3902@habkost.net> (raw)
In-Reply-To: <20181030111348.14713-2-kraxel@redhat.com>
On Tue, Oct 30, 2018 at 12:13:45PM +0100, Gerd Hoffmann wrote:
> Indicates support state for somerhing (device, backend, subsystem, ...)
> in qemu. Modeled roughly after the "S:" states we have in MAINTANERS.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
[...]
> +typedef struct QemuSupportState {
> + SupportState state;
> + const char *reason;
> +} QemuSupportState;
I find it weird that we're calling this field "reason", while
this is how the field is being actually used:
* "use a newer machine type instead"
* "use 40p machine type instead"
* "use '-vga std' instead"
These are not reasons for deprecation, they are just suggested
alternatives.
--
Eduardo
next prev parent reply other threads:[~2018-10-30 15:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 11:13 [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState Gerd Hoffmann
2018-10-30 11:13 ` [Qemu-devel] [PATCH 1/4] add QemuSupportState Gerd Hoffmann
2018-10-30 13:32 ` Philippe Mathieu-Daudé
2018-10-30 14:00 ` Gerd Hoffmann
2018-10-30 14:13 ` Philippe Mathieu-Daudé
2018-10-30 15:46 ` Cornelia Huck
2018-10-30 17:37 ` Philippe Mathieu-Daudé
2018-10-30 23:15 ` Eduardo Habkost
2018-10-31 9:22 ` Cornelia Huck
2018-11-05 7:30 ` Gerd Hoffmann
2018-11-05 13:49 ` Eduardo Habkost
2018-11-06 6:56 ` Gerd Hoffmann
2018-10-31 16:04 ` John Snow
2018-10-31 18:06 ` Eduardo Habkost
2018-10-31 18:37 ` John Snow
2018-10-31 18:58 ` Eduardo Habkost
2018-10-31 20:05 ` John Snow
2018-11-05 7:46 ` Gerd Hoffmann
2018-10-30 14:54 ` Eduardo Habkost
2018-10-30 15:02 ` Eduardo Habkost [this message]
2018-10-30 17:30 ` [Qemu-devel] [Qemu-ppc] " Murilo Opsfelder Araujo
2018-10-30 11:13 ` [Qemu-devel] [PATCH 2/4] add QemuSupportState to DeviceClass Gerd Hoffmann
2018-10-30 11:13 ` [Qemu-devel] [PATCH 3/4] tag cirrus as obsolete Gerd Hoffmann
2018-10-30 11:22 ` Paolo Bonzini
2018-10-30 11:13 ` [Qemu-devel] [PATCH 4/4] switch machine types to QemuSupportState Gerd Hoffmann
2018-10-30 11:22 ` [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState Paolo Bonzini
2018-10-30 14:34 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030150200.GW3902@habkost.net \
--to=ehabkost@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).