From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: wangguang <wang.guang55@zte.com.cn>,
qemu-devel@nongnu.org, qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary
Date: Tue, 30 Oct 2018 16:42:55 +0000 [thread overview]
Message-ID: <20181030164255.GA7305@work-vm> (raw)
In-Reply-To: <28d15bd5-1620-b39b-ed92-d8812d1549c8@redhat.com>
* Eric Blake (eblake@redhat.com) wrote:
> [adding qemu-trivial]
>
> On 03/20/2017 07:27 PM, wangguang wrote:
> > Subject: [PATCH] Fix Colo doc secondeary should be secondary
>
> This line feels redundant compared to the overall mail's subject line.
> In turn, that subject could use a space after colon.
>
> > This is an error in COLO-FT.txt.
> > secondeary-disk0 should be secondary-disk0.
> >
> > Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>
> > ---
> > docs/COLO-FT.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> As it is doc-only, it is safe for hard freeze, but also not the end of
> the world if it doesn't go in until 2.10.
Manually applied and queued for migration
(ahem a little late)
Dave
> >
> > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt
> > index e289be2..bec7547 100644
> > --- a/docs/COLO-FT.txt
> > +++ b/docs/COLO-FT.txt
> > @@ -139,7 +139,7 @@ Secondary:
> > { 'execute': 'nbd-server-start',
> > 'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
> > 'port': '8889'} } }
> > }
> > -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
> > 'writable': true } }
> > +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
> > 'writable': true } }
> >
> > Note:
> > a. The qmp command nbd-server-start and nbd-server-add must be run
> >
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-10-30 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 0:27 [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary wangguang
2017-03-21 1:02 ` Eric Blake
2018-10-30 16:42 ` Dr. David Alan Gilbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-20 11:57 [Qemu-devel] [PATCH v3]COLO:Fix " wangguang
2017-03-21 0:26 ` [Qemu-devel] [PATCH v4]COLO:Fix " wangguang
2017-03-21 3:05 ` Eric Blake
2017-03-21 3:12 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030164255.GA7305@work-vm \
--to=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wang.guang55@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).