From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jeff Cody <jcody@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Daniel Berrange <berrange@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 2/4] get_maintainer: use 'https://' instead of 'git://'
Date: Wed, 31 Oct 2018 08:43:07 +0000 [thread overview]
Message-ID: <20181031084309.9227-3-stefanha@redhat.com> (raw)
In-Reply-To: <20181031084309.9227-1-stefanha@redhat.com>
When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks. HTTPS is more secure
since the client verifies the server certificate.
Reported-by: Jann Horn <jannh@google.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 43fb5f512f..fc7275b9e2 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1376,7 +1376,7 @@ sub vcs_exists {
warn("$P: No supported VCS found. Add --nogit to options?\n");
warn("Using a git repository produces better results.\n");
warn("Try latest git repository using:\n");
- warn("git clone git://git.qemu.org/qemu.git\n");
+ warn("git clone https//git.qemu.org/git/qemu.git\n");
$printed_novcs = 1;
}
return 0;
--
2.17.2
next prev parent reply other threads:[~2018-10-31 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 8:43 [Qemu-devel] [PATCH 0/4] Use 'https://' instead of 'git://' Stefan Hajnoczi
2018-10-31 8:43 ` [Qemu-devel] [PATCH 1/4] README: use " Stefan Hajnoczi
2018-10-31 9:51 ` Daniel P. Berrangé
2018-10-31 8:43 ` Stefan Hajnoczi [this message]
2018-10-31 9:52 ` [Qemu-devel] [PATCH 2/4] get_maintainer: " Daniel P. Berrangé
2018-10-31 8:43 ` [Qemu-devel] [PATCH 3/4] MAINTAINERS: use 'https://' instead of 'git://' for GitHub Stefan Hajnoczi
2018-10-31 9:57 ` Daniel P. Berrangé
2018-10-31 10:05 ` Cornelia Huck
2018-10-31 13:31 ` Eric Blake
2018-11-02 12:36 ` Stefan Hajnoczi
2018-10-31 8:43 ` [Qemu-devel] [PATCH 4/4] gitmodules: use 'https://' instead of 'git://' Stefan Hajnoczi
2018-10-31 10:01 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031084309.9227-3-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jcody@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).