* [Qemu-devel] [PATCH] vhost-user-bridge: fix "unknown type name" compilation error
@ 2018-10-31 10:41 Marc-André Lureau
2018-10-31 11:25 ` Michal Privoznik
2018-10-31 15:59 ` Emilio G. Cota
0 siblings, 2 replies; 3+ messages in thread
From: Marc-André Lureau @ 2018-10-31 10:41 UTC (permalink / raw)
To: qemu-devel; +Cc: victork, cota, pbonzini, Marc-André Lureau
osdep.h should be included first:
CC tests/vhost-user-bridge.o
In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
/home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name ‘int64_t’
int64_t atomic_read_i64(const int64_t *ptr);
^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:480:32: error: unknown type name ‘int64_t’
int64_t atomic_read_i64(const int64_t *ptr);
^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:481:1: error: unknown type name ‘uint64_t’
uint64_t atomic_read_u64(const uint64_t *ptr);
^~~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:481:32: error: unknown type name ‘uint64_t’
uint64_t atomic_read_u64(const uint64_t *ptr);
^~~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:482:21: error: unknown type name ‘int64_t’
void atomic_set_i64(int64_t *ptr, int64_t val);
^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:482:35: error: unknown type name ‘int64_t’
void atomic_set_i64(int64_t *ptr, int64_t val);
^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:483:21: error: unknown type name ‘uint64_t’
void atomic_set_u64(uint64_t *ptr, uint64_t val);
^~~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:483:36: error: unknown type name ‘uint64_t’
void atomic_set_u64(uint64_t *ptr, uint64_t val);
^~~~~~~~
(regression from 782da5b2921c4d18777d5d5bd9385b9f7beae360)
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/vhost-user-bridge.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 0884294141..6e17370397 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -29,8 +29,9 @@
#define _FILE_OFFSET_BITS 64
-#include "qemu/atomic.h"
#include "qemu/osdep.h"
+
+#include "qemu/atomic.h"
#include "qemu/iov.h"
#include "standard-headers/linux/virtio_net.h"
#include "contrib/libvhost-user/libvhost-user.h"
--
2.19.1.708.g4ede3d42df
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-user-bridge: fix "unknown type name" compilation error
2018-10-31 10:41 [Qemu-devel] [PATCH] vhost-user-bridge: fix "unknown type name" compilation error Marc-André Lureau
@ 2018-10-31 11:25 ` Michal Privoznik
2018-10-31 15:59 ` Emilio G. Cota
1 sibling, 0 replies; 3+ messages in thread
From: Michal Privoznik @ 2018-10-31 11:25 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: pbonzini, victork, cota
On 10/31/2018 11:41 AM, Marc-André Lureau wrote:
> osdep.h should be included first:
>
> CC tests/vhost-user-bridge.o
> In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
> /home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name ‘int64_t’
> int64_t atomic_read_i64(const int64_t *ptr);
> ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:480:32: error: unknown type name ‘int64_t’
> int64_t atomic_read_i64(const int64_t *ptr);
> ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:481:1: error: unknown type name ‘uint64_t’
> uint64_t atomic_read_u64(const uint64_t *ptr);
> ^~~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:481:32: error: unknown type name ‘uint64_t’
> uint64_t atomic_read_u64(const uint64_t *ptr);
> ^~~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:482:21: error: unknown type name ‘int64_t’
> void atomic_set_i64(int64_t *ptr, int64_t val);
> ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:482:35: error: unknown type name ‘int64_t’
> void atomic_set_i64(int64_t *ptr, int64_t val);
> ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:483:21: error: unknown type name ‘uint64_t’
> void atomic_set_u64(uint64_t *ptr, uint64_t val);
> ^~~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:483:36: error: unknown type name ‘uint64_t’
> void atomic_set_u64(uint64_t *ptr, uint64_t val);
> ^~~~~~~~
>
> (regression from 782da5b2921c4d18777d5d5bd9385b9f7beae360)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/vhost-user-bridge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Funny, I was just looking into this right now :-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] vhost-user-bridge: fix "unknown type name" compilation error
2018-10-31 10:41 [Qemu-devel] [PATCH] vhost-user-bridge: fix "unknown type name" compilation error Marc-André Lureau
2018-10-31 11:25 ` Michal Privoznik
@ 2018-10-31 15:59 ` Emilio G. Cota
1 sibling, 0 replies; 3+ messages in thread
From: Emilio G. Cota @ 2018-10-31 15:59 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, victork, pbonzini
On Wed, Oct 31, 2018 at 14:41:36 +0400, Marc-André Lureau wrote:
> osdep.h should be included first:
>
> CC tests/vhost-user-bridge.o
> In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
> /home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name ‘int64_t’
> int64_t atomic_read_i64(const int64_t *ptr);
(snip)
> (regression from 782da5b2921c4d18777d5d5bd9385b9f7beae360)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Emilio G. Cota <cota@braap.org>
Thanks,
Emilio
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-31 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-31 10:41 [Qemu-devel] [PATCH] vhost-user-bridge: fix "unknown type name" compilation error Marc-André Lureau
2018-10-31 11:25 ` Michal Privoznik
2018-10-31 15:59 ` Emilio G. Cota
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).